Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a script adding "Countries where sold" to products as prices are added #263

Open
teolemon opened this issue Apr 1, 2024 · 9 comments

Comments

@teolemon
Copy link
Member

teolemon commented Apr 1, 2024

Problem

  • Create a script adding "Countries where sold" to products as prices are added
  • This requires
  • deducing the country from the associated stores
  • checking whether the product already has this country in "Countries where sold"
  • if not adding it.

Why

  • We currently add countries yearly using scan statistics
  • Prices allow us doing that in almost real time, much more aggressively and reliably than scan statistics

Related

discussion "Send data to Open Food Facts" : #223

@teolemon teolemon added the ✨ enhancement New feature or request label Apr 1, 2024
@raphodn
Copy link
Member

raphodn commented Apr 1, 2024

These contributions to OFF would be attributed to which user ? Is there a good practice ?

@teolemon
Copy link
Member Author

teolemon commented Apr 1, 2024

@teolemon
Copy link
Member Author

@raphodn
Copy link
Member

raphodn commented Aug 24, 2024

image

We could add a few rules :

  • City, state & country where purchased : real-time
  • Stores : real-time
  • Countries where sold : after at least X prices in Y different locations in a given country ?

@raphodn
Copy link
Member

raphodn commented Aug 24, 2024

For the auth, we could also create an openprices user, and pass a uuid per user in the comments.

I feel its simpler, and also better because the user didn't actually edit the product, its done in the background, so it would be weird for many users to have these products pop up in their "recently modified" list

foodvisor seems to have this mecanism

@teolemon
Copy link
Member Author

teolemon commented Oct 23, 2024

@stephanegigandet @aleene @alexgarel @raphodn @raphael0202 would like your opinions on the matter.

  • It would be very interesting to delegate the handling of those fields to Open Prices or Open Food Facts events (we have 3 kind of competing systems to store "Where it is sold" info, and 2 main sources (Scans and Prices)

Image

@raphael0202
Copy link
Contributor

The issue with the 'Stores' field is that it's dynamic: especially as we don't have any date associated to it, there is no way to know whether the information is still valid. I would be in favor of dropping completely the Stores field, along with the City, state and country of purchase, which I find of very limited interest (at least comparing to the kind of data Open Prices can provide).

Updating periodically the Countries field using Open Prices data sounds like a good idea to me though!

@alexgarel
Copy link
Member

IMO, for the stores data, it is a data of interest, even if contrarily to Open Prices, this is not a "sold now" data, so I would keep it, as complementary to what Open Prices provides.

@aleene
Copy link

aleene commented Jan 13, 2025

The discussion should be broaded to the question how Prices can and should be integrated into OFF. Although the shops and locations (and thus countries) from Prices offer more accurate and recent info, it should not be the only sources. OFF needs to be more strict and move away rrom the text fields, to structured data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Ready
Development

No branches or pull requests

5 participants