Skip to content

Commit 39caa34

Browse files
authored
Merge pull request #134 from checkr/zz/add-offset-support
Add offset support
2 parents 7cf9a20 + 0f71984 commit 39caa34

File tree

8 files changed

+74
-5
lines changed

8 files changed

+74
-5
lines changed

docs/api_docs/bundle.yaml

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ info:
44
Flagr is a feature flagging, A/B testing and dynamic configuration
55
microservice
66
title: Flagr
7-
version: 1.0.0
7+
version: 1.0.7
88
tags:
99
- name: flag
1010
description: Everything about the flag
@@ -60,6 +60,13 @@ paths:
6060
name: description_like
6161
type: string
6262
description: return flags partially matching given description
63+
- in: query
64+
name: offset
65+
type: integer
66+
format: int64
67+
description: >-
68+
return flags given the offset, it should usually set together with
69+
limit
6370
responses:
6471
'200':
6572
description: list all the flags

pkg/handler/crud.go

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -81,6 +81,9 @@ func (c *crud) FindFlags(params flag.FindFlagsParams) middleware.Responder {
8181
if params.Limit != nil {
8282
q = q.Limit(int(*params.Limit))
8383
}
84+
if params.Offset != nil {
85+
q = q.Offset(int(*params.Offset))
86+
}
8487

8588
err := q.All(&fs)
8689
if err != nil {

swagger/flags.yaml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,11 @@ get:
2020
name: description_like
2121
type: string
2222
description: return flags partially matching given description
23+
- in: query
24+
name: offset
25+
type: integer
26+
format: int64
27+
description: return flags given the offset, it should usually set together with limit
2328
responses:
2429
200:
2530
description: list all the flags

swagger/index.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ swagger: "2.0"
33
info:
44
description: Flagr is a feature flagging, A/B testing and dynamic configuration microservice
55
title: Flagr
6-
version: 1.0.0
6+
version: 1.0.7
77
tags:
88
- name: flag
99
description: Everything about the flag

swagger_gen/restapi/doc.go

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

swagger_gen/restapi/embedded_spec.go

Lines changed: 16 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

swagger_gen/restapi/operations/flag/find_flags_parameters.go

Lines changed: 31 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

swagger_gen/restapi/operations/flag/find_flags_urlbuilder.go

Lines changed: 9 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)