Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add version and changes check to openfisca command or task manager #1284

Open
bonjourmauko opened this issue Oct 18, 2024 · 3 comments
Open
Labels
kind:build Pull requests that update a dependency file

Comments

@bonjourmauko
Copy link
Member

bonjourmauko commented Oct 18, 2024

Hi there!

I really enjoy OpenFisca, but I recently encountered an issue.

Here is what I did:

I'm normalising the toolbox for maintainers and contributors.

Here is what I expected to happen:

There should be just one tool to do all the checks required to contribute.

Here is what actually happened:

There are different sh files across several repositories.

These should all be handled either by a task manager or by the openfisca command.

Here is data (or links to it) that can help you reproduce this issue:

#1040 (comment)
openfisca/extension-template#58

@bonjourmauko bonjourmauko added the kind:build Pull requests that update a dependency file label Oct 18, 2024
@MattiSG
Copy link
Member

MattiSG commented Oct 21, 2024

My intention was to use https://github.com/OpenTermsArchive/changelog-action 🙂

@bonjourmauko
Copy link
Member Author

My intention was to use https://github.com/OpenTermsArchive/changelog-action 🙂

TBH, these checks have little to do in the dev tool (Makefile, Taskfile, etc.). Go for it.

@bonjourmauko
Copy link
Member Author

BTW I've use python-semantic-release in another project and works quite effortlessly:
https://github.com/openfisca/openfisca-setup-builder/blob/main/.github/workflows/default.yaml#L63

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:build Pull requests that update a dependency file
Projects
None yet
Development

No branches or pull requests

2 participants