Skip to content
This repository has been archived by the owner on Mar 7, 2020. It is now read-only.

Update Base Image to Node 10 #13

Open
Templum opened this issue Oct 25, 2018 · 4 comments
Open

Update Base Image to Node 10 #13

Templum opened this issue Oct 25, 2018 · 4 comments
Labels
design/review question Further information is requested

Comments

@Templum
Copy link

Templum commented Oct 25, 2018

Node 10 will be released on the 2018-10-30 and will become the new LTS. If that happens we should update the base image to Node 10.

Also it might be advisable to rename the repository. As it containts node8

@alexellis
Copy link
Member

Renaming the repository will break for so many people, that's not really an option.

A new repository with an alternative name seems like the sane thing to do right now - that or make "LTS" a moving target - node-lts-express (but this may also cause breakage for people moving between LTS versions).

Alex

@alexellis
Copy link
Member

@alexellis alexellis added question Further information is requested design/review labels Oct 26, 2018
@rimiti
Copy link

rimiti commented Oct 26, 2018

@alexellis Why did you not created node-express-template instead of node10-express-template ? I don't understand why it's necessary to add node version into the name of the repository.

@alexellis
Copy link
Member

It's important to make sure that we do not break a user's functions and production workflow. If there is a breaking change between two Node versions then that needs to be mitigated. By using a version in the repository we can allow both to be used at once and leave it up to the developer/company to move when they want. Does this make sense?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
design/review question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants