Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use git pre-commit hooks to verify changes #270

Open
crass opened this issue Oct 29, 2019 · 3 comments
Open

Use git pre-commit hooks to verify changes #270

crass opened this issue Oct 29, 2019 · 3 comments

Comments

@crass
Copy link
Contributor

crass commented Oct 29, 2019

I'm not sure the best way to do this, but it seems like we might want some functionality where created pull requests are checked to verify that they meet the CONTRIBUTING.md rules and perhaps some extra ones, like normalized names, no empty field names, no empty rows, etc.. I believe this can be implemented with a webhook triggered on pull request creation.

@alanhuang122
Copy link
Contributor

I played around with this thought (using status checks, for example) a while ago, but never got around to actually doing any checks. If it's deemed worth the effort, I could revisit the idea.

@crass
Copy link
Contributor Author

crass commented Oct 29, 2019

I figured I'd get this up as an issue. I'm not sure if its worth the effort, but it seems like this could be used across all state repositories. Perhaps making it more valuable.

@warwickmm
Copy link
Member

The data tests and format tests workflows are an attempt at this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants