Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for JS-based config in frontend-platform #11

Closed
1 task done
davidjoy opened this issue Oct 4, 2021 · 1 comment · Fixed by openedx/frontend-platform#474
Closed
1 task done

Support for JS-based config in frontend-platform #11

davidjoy opened this issue Oct 4, 2021 · 1 comment · Fixed by openedx/frontend-platform#474
Assignees
@davidjoy
Labels
enhancement Relates to new features or improvements to existing features

Comments

@davidjoy
Copy link
Contributor

davidjoy commented Oct 4, 2021 •
edited by arbrandes
Loading

https://github.com/edx/frontend-platform needs to be updated to allow for JS-based configuration.

This should look something like:

  • Packaging the existing process.env configuration into a ProcessEnvConfigService and putting an interface.js abstraction layer around it.
  • Create an ImportConfigService (or a better name) which imports configuration from 'env.config', as expected in frontend-build.
  • Determine the right rollout strategy which enables backwards compatibility with the existing process.env-based configuration, while allowing MFEs to opt into the JS-based configuration.

PRs
Preview Give feedback
  1. feat: JavaScript file configuration of apps frontend-platform#474
@davidjoy davidjoy added this to the MFE Config 2.0 milestone Oct 4, 2021
@davidjoy davidjoy mentioned this issue Dec 2, 2021
Open
11 tasks
@ghassanmas
Copy link
Member

@davidjoy is this open for the community to own? or is it something edx is already working on internally?
I ask because I am interested in working on it (given also this has been brought up in the last FEWG #49)

@arbrandes arbrandes moved this to Backlog in Frontend Working Group Jan 23, 2023
@arbrandes arbrandes added the enhancement Relates to new features or improvements to existing features label Jan 23, 2023
@davidjoy davidjoy mentioned this issue Apr 11, 2023
Merged
4 tasks
@arbrandes arbrandes moved this from Backlog to In review in Frontend Working Group May 25, 2023
@github-project-automation github-project-automation bot moved this from In review to Closed in Frontend Working Group May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davidjoy davidjoy

Labels
enhancement Relates to new features or improvements to existing features
Projects
Frontend Working Group
Status: Closed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: JavaScript file configuration of apps davidjoy/frontend-platform
3 participants
@davidjoy @arbrandes @ghassanmas