Skip to content

Commit 2a8793d

Browse files
authored
fix: updating frontend-base to 3.0.0 (#7)
Also locking package.json versions and updating associated @edx libraries
1 parent f9d1734 commit 2a8793d

File tree

3 files changed

+77
-88
lines changed

3 files changed

+77
-88
lines changed

package-lock.json

Lines changed: 32 additions & 41 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 38 additions & 38 deletions
Original file line numberDiff line numberDiff line change
@@ -29,51 +29,51 @@
2929
},
3030
"homepage": "https://github.com/edx/frontend-component-header#readme",
3131
"devDependencies": {
32-
"@babel/cli": "^7.6.0",
33-
"@babel/core": "^7.6.0",
34-
"@babel/plugin-proposal-class-properties": "^7.5.5",
35-
"@babel/plugin-proposal-object-rest-spread": "^7.5.5",
36-
"@babel/preset-env": "^7.6.0",
37-
"@babel/preset-react": "^7.0.0",
38-
"@edx/frontend-analytics": "^2.0.0",
39-
"@edx/frontend-auth": "^6.0.1",
40-
"@edx/frontend-base": "^2.0.0",
41-
"@edx/frontend-i18n": "^3.0.2",
42-
"@edx/frontend-logging": "^3.0.1",
43-
"@edx/paragon": "^7.1.2",
44-
"babel-eslint": "^10.0.3",
45-
"babel-plugin-react-intl": "^4.1.18",
46-
"dotenv": "^8.1.0",
32+
"@babel/cli": "7.6.0",
33+
"@babel/core": "7.6.0",
34+
"@babel/plugin-proposal-class-properties": "7.5.5",
35+
"@babel/plugin-proposal-object-rest-spread": "7.5.5",
36+
"@babel/preset-env": "7.6.0",
37+
"@babel/preset-react": "7.0.0",
38+
"@edx/frontend-analytics": "3.0.0",
39+
"@edx/frontend-auth": "7.0.1",
40+
"@edx/frontend-base": "3.0.0",
41+
"@edx/frontend-i18n": "3.0.3",
42+
"@edx/frontend-logging": "3.0.1",
43+
"@edx/paragon": "7.1.4",
44+
"babel-eslint": "10.0.3",
45+
"babel-plugin-react-intl": "4.1.18",
46+
"dotenv": "8.1.0",
4747
"enzyme": "3.10.0",
4848
"enzyme-adapter-react-16": "1.14.0",
49-
"eslint": "^6.3.0",
50-
"eslint-config-edx": "^4.0.4",
51-
"jest": "^24.9.0",
52-
"parcel-bundler": "^1.12.3",
53-
"prop-types": "^15.7.2",
54-
"react": "^16.9.0",
55-
"react-dom": "^16.9.0",
56-
"react-redux": "^7.1.1",
57-
"react-router-dom": "^5.0.1",
58-
"react-test-renderer": "^16.9.0",
59-
"reactifex": "^1.1.1",
60-
"redux": "^4.0.4",
61-
"redux-saga": "^1.0.5",
62-
"sass": "^1.22.12",
63-
"semantic-release": "^15.13.24"
49+
"eslint": "6.3.0",
50+
"eslint-config-edx": "4.0.4",
51+
"jest": "24.9.0",
52+
"parcel-bundler": "1.12.3",
53+
"prop-types": "15.7.2",
54+
"react": "16.9.0",
55+
"react-dom": "16.9.0",
56+
"react-redux": "7.1.1",
57+
"react-router-dom": "5.0.1",
58+
"react-test-renderer": "16.9.0",
59+
"reactifex": "1.1.1",
60+
"redux": "4.0.4",
61+
"redux-saga": "1.0.5",
62+
"sass": "1.22.12",
63+
"semantic-release": "15.13.24"
64+
},
65+
"dependencies": {
66+
"babel-polyfill": "6.26.0",
67+
"react-responsive": "8.0.1",
68+
"react-transition-group": "4.3.0"
6469
},
6570
"peerDependencies": {
66-
"@edx/frontend-analytics": "^2.0.0",
67-
"@edx/frontend-base": "^2.0.0",
68-
"@edx/frontend-i18n": "^3.0.2",
71+
"@edx/frontend-analytics": "^3.0.0",
72+
"@edx/frontend-base": "^3.0.0",
73+
"@edx/frontend-i18n": "^3.0.3",
6974
"prop-types": "^15.7.2",
7075
"react": "^16.9.0"
7176
},
72-
"dependencies": {
73-
"babel-polyfill": "^6.26.0",
74-
"react-responsive": "^8.0.1",
75-
"react-transition-group": "^4.3.0"
76-
},
7777
"jest": {
7878
"transform": {
7979
"^.+\\.jsx?$": "babel-jest"

src/SiteHeader.jsx

Lines changed: 7 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import React, { useContext } from 'react';
22
import Responsive from 'react-responsive';
33
import { injectIntl, intlShape } from '@edx/frontend-i18n';
4-
import { App, AppContext, APP_CONFIGURED } from '@edx/frontend-base';
4+
import { App, AppContext } from '@edx/frontend-base';
55

66
import DesktopHeader from './DesktopHeader';
77
import MobileHeader from './MobileHeader';
@@ -10,14 +10,12 @@ import LogoSVG from './logo.svg';
1010

1111
import messages from './SiteHeader.messages';
1212

13-
App.subscribe(APP_CONFIGURED, () => {
14-
App.requireConfig([
15-
'LMS_BASE_URL',
16-
'LOGOUT_URL',
17-
'LOGIN_URL',
18-
'SITE_NAME',
19-
], 'Header component');
20-
});
13+
App.requireConfig([
14+
'LMS_BASE_URL',
15+
'LOGOUT_URL',
16+
'LOGIN_URL',
17+
'SITE_NAME',
18+
], 'Header component');
2119

2220
function SiteHeader({ intl }) {
2321
const { authenticatedUser, config } = useContext(AppContext);

0 commit comments

Comments
 (0)