Skip to content

UI Show Completion even when completion.enable_completion_tracking is disabled. #1692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
feanil opened this issue Apr 29, 2025 · 2 comments · Fixed by #1714
Closed

UI Show Completion even when completion.enable_completion_tracking is disabled. #1692

feanil opened this issue Apr 29, 2025 · 2 comments · Fixed by #1714
Assignees
@holaontiveros
Labels
bug Report of or fix for something that isn't working as intended

Comments

@feanil
Copy link
Contributor

feanil commented Apr 29, 2025

Steps to Reproduce:

  1. Enabled the completion.enable_completion_tracking waffle switch in edx-platform.
  2. As you browse a course in the learning MFE, stay on each component for 10secs - 1 minute (long enough to mark the unit as completed.
  3. When you go to the next section, the nav should update to show the previous section has been completed.
    Image
  4. Next disable the completion.enable_completion_tracking waffle switch.
  5. Refresh the learning MFE, and you'll still see the green checkmarks.

This is a bug, if the completion tracking is disabled, you should not see elements in the UI that show completion related information.
@feanil feanil added the bug Report of or fix for something that isn't working as intended label Apr 29, 2025
@sarina
Copy link
Contributor

sarina commented Apr 29, 2025

This is approved to work on from a Product perspective ✅

@holaontiveros
Copy link
Contributor

assign me

@holaontiveros holaontiveros mentioned this issue May 23, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@holaontiveros holaontiveros

Labels
bug Report of or fix for something that isn't working as intended
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(OEXCOM-80): disable completion item icons on flag holaontiveros/frontend-app-learning
3 participants
@feanil @sarina @holaontiveros