Skip to content

Commit bad1246

Browse files
feat: import FooterSlot from component package instead of slot package (#765)
1 parent ec915f6 commit bad1246

File tree

6 files changed

+14
-27
lines changed

6 files changed

+14
-27
lines changed

.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ node_modules
66
npm-debug.log
77
coverage
88
module.config.js
9+
env.config.*
910

1011
dist/
1112
src/i18n/transifex_input.json

package-lock.json

Lines changed: 5 additions & 19 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,11 +30,10 @@
3030
},
3131
"dependencies": {
3232
"@edx/brand": "npm:@openedx/brand-openedx@^1.2.2",
33-
"@edx/frontend-component-footer": "^14.3.0",
33+
"@edx/frontend-component-footer": "^14.6.0",
3434
"@edx/frontend-component-header": "^6.2.0",
3535
"@edx/frontend-platform": "^8.3.3",
3636
"@edx/openedx-atlas": "^0.6.0",
37-
"@openedx/frontend-slot-footer": "^1.1.0",
3837
"@openedx/paragon": "^22.16.0",
3938
"@reduxjs/toolkit": "1.9.7",
4039
"@tinymce/tinymce-react": "5.1.1",

src/discussions/discussions-home/DiscussionsHome.jsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ import { selectPostEditorVisible } from '../posts/data/selectors';
2727
import { isCourseStatusValid } from '../utils';
2828
import useFeedbackWrapper from './FeedbackWrapper';
2929

30-
const FooterSlot = lazy(() => import('@openedx/frontend-slot-footer'));
30+
const FooterSlot = lazy(() => import('@edx/frontend-component-footer').then(module => ({ default: module.FooterSlot })));
3131
const PostActionsBar = lazy(() => import('../posts/post-actions-bar/PostActionsBar'));
3232
const CourseTabsNavigation = lazy(() => import('../../components/NavigationBar/CourseTabsNavigation'));
3333
const LegacyBreadcrumbMenu = lazy(() => import('../navigation/breadcrumb-menu/LegacyBreadcrumbMenu'));

src/plugin-slots/FooterSlot/README.md

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,13 @@
11
# Footer Slot
22

3-
### Slot ID: `footer_slot`
3+
### Slot ID: `org.openedx.frontend.layout.footer.v1`
44

5-
## Description
5+
### Slot ID Aliases
6+
* `footer_slot`
67

78
This slot is used to replace/modify/hide the footer.
89

9-
The implementation of the `FooterSlot` component lives in [the `frontend-slot-footer` repository](https://github.com/openedx/frontend-slot-footer/).
10+
The implementation of the `FooterSlot` component lives in [the `frontend-component-footer` repository](https://github.com/openedx/frontend-component-footer/).
1011

1112
## Example
1213

@@ -23,7 +24,7 @@ import { DIRECT_PLUGIN, PLUGIN_OPERATIONS } from '@openedx/frontend-plugin-frame
2324

2425
const config = {
2526
pluginSlots: {
26-
footer_slot: {
27+
'org.openedx.frontend.layout.footer.v1': {
2728
plugins: [
2829
{
2930
// Hide the default footer

src/plugin-slots/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
# `frontend-app-discussions` Plugin Slots
22

3-
* [`footer_slot`](./FooterSlot/)
3+
* [`org.openedx.frontend.layout.footer.v1`](./FooterSlot/)

0 commit comments

Comments
 (0)