When the replace video button is clicked, the page goes blank

[mariajgrimaldi]

When selecting replace video from the video editor the page goes blank without any error message in the console or any indication of what went wrong.

Expected behavior

It is expected that clicking the replace video button will redirect the page to the unit where the component is located.

Actual behavior

When you click the replace video button, the page appears blank because it is not redirecting properly.

Steps to reproduce

1. Add a new video component.
2. Edit the component
3. Click the 'replace video' button.

Additional information

Originally reported here: openedx/wg-build-test-release#418

[mariajgrimaldi]

@arbrandes @bradenmacdonald @openedx/2u-tnl, tagging you for visibility. Please, tag who you think can help us solve this issue. Thank you!

[bradenmacdonald]

I'm not familiar with this, sorry. Why do we have a link back to the unit page anyways? It seems different than the other editors which should all use the same "Cancel" button to close the modal.

[mariajgrimaldi]

I completely forgot to update the issue with what @farhaanbukhsh found about this feature. Sorry. Here's the thread: https://openedx.slack.com/archives/C049JQZFR5E/p1733414487074569

[farhaanbukhsh]

@mariajgrimaldi @bradenmacdonald you can also have a look at the Figma board

https://www.figma.com/design/cS42BX4OUsR8lOw6ppZHoz/Content-Libraries

Replace video should be redirected to the Gallery of videos and if this is not working it's possibly a bug.

[mariajgrimaldi]

@crathbun428: Could you help us figure out whether this should be working?

[farhaanbukhsh]

@mariajgrimaldi I looked at this PR openedx-unsupported/frontend-lib-content-components#412
and I am wondering did we enable new_core_editors.use_video_gallery_flow flag?

[crathbun428]

@mariajgrimaldi - I agree with @bradenmacdonald - there is a way to save and there is a way to cancel. I'm inclined to say the whole replace video link and arrow icon should be removed from this page entirely.

cc: @jmakowski1123

[mariajgrimaldi]

@farhaanbukhsh: I tried using the new_core_editors.use_video_gallery_flow and the video creation flow stops working completely 👀

Screencast.from.19-12-24.21.19.27.webm

Thank you, @crathbun428. What do you think about what Farhaan mentioned about the library functionality in this comment?

[crathbun428]

@jmakowski1123 - There is a question about how the video editor should work. Specifically, the Replace Video link seems to not function properly when clicked. Initially, we were wondering if this link should just be removed and/or replaced with a modal close button, but Faarhan raises that the way this should work is dictated by the libraries design in his comment here. How should this Replace Video link behave at this point in the libraries development?

[jmakowski1123]

I believe the way the "Replace Video" link is supposed to work is to redirect to the Video Uploads page. However, the Video Uploads page is a 2U-specific page that is off by default for the community release. (It is also going to be deprecated and rebuilt by 2U as a plugin.) So I suspect this button was created with the 2U-specific workflow in mind.

I think we need to explore a few options:

1. Can we get rid of that button? I suspect not, because it's likely 2U is using it. Pinging @cablaa77 for some insight?
2. Can we hide that button in the community release?
3. What would it take to make that space on the editor pluggable? I suspect this would be a huge and complicated lift.

It looks like we actually removed that button in the library version of the video editor. The library workflow would not have an impact on the 2U video pipeline.

[bra-i-am]

hey, I created a new merge request #1915 where I try to solve this issue; there I changed some URLs to add the prefix /authoring/ so the redirect to the Video Uploads page works properly, and taking into account that...

the Video Uploads page is a 2U-specific page that is off by default for the community release

... I made the required modifications to hide the button Replace video when the flag contentstore.new_studio_mfe.use_new_video_uploads_page is off

Please let me know your comments!

cc. @mariajgrimaldi @jmakowski1123 @crathbun428