Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

do not attempt to delete the ZFSVolume CR if there is a snapshot holding it. #123

Open
pawanpraka1 opened this issue May 20, 2020 · 5 comments · May be fixed by #350
Open

do not attempt to delete the ZFSVolume CR if there is a snapshot holding it. #123

pawanpraka1 opened this issue May 20, 2020 · 5 comments · May be fixed by #350
Assignees
@sinhaashish
Labels
backlog Will be picked up as a roadmap item. enhancement Add new functionality to existing feature
Milestone
v4.2

Comments

@pawanpraka1
Copy link
Contributor

pawanpraka1 commented May 20, 2020 •
edited
Loading

ZFSPV allows to delete the volume if snapshot exist for that volume.In this case the node agent keeps on trying to delete the volume and fails to do so since there is a snapshot for the volume, but the PVC and PV get deleted.

Here, we can fail the ZFSVolume deletion, if there is a snapshot on it. PVC will still be deleted and in background the CSI Provisioner will keep on trying to delete the volume and we keep on failing that request until there is a snapshot on it.

Before attempting the delete here :

zfs-localpv/pkg/driver/controller.go

Line 271 in d47ec3b

err = zfs.DeleteVolume(volumeID)

We should check for snapshot and if it exist, fail the deletion.
@pawanpraka1 pawanpraka1 added this to the v0.8.0 milestone May 20, 2020
@pawanpraka1 pawanpraka1 added the enhancement Add new functionality to existing feature label May 20, 2020
@pawanpraka1 pawanpraka1 changed the title [enhancement] fail the PVC deletion if there is a snapshot on it. fail the PVC deletion if there is a snapshot on it. May 20, 2020
@pawanpraka1 pawanpraka1 added good first issue Good for newcomers and removed good first issue Good for newcomers labels May 21, 2020
@pawanpraka1 pawanpraka1 changed the title fail the PVC deletion if there is a snapshot on it. fail the ZFSVolume if there is a snapshot on it. May 26, 2020
@pawanpraka1 pawanpraka1 changed the title fail the ZFSVolume if there is a snapshot on it. fail the ZFSVolume deletion if there is a snapshot on it. May 26, 2020
@pawanpraka1 pawanpraka1 changed the title fail the ZFSVolume deletion if there is a snapshot on it. do not attempt to delete the ZFSVolume CR if there is a snapshot on it. May 26, 2020
@pawanpraka1 pawanpraka1 changed the title do not attempt to delete the ZFSVolume CR if there is a snapshot on it. do not attempt to delete the ZFSVolume CR if there is a snapshot holding it. May 26, 2020
@pawanpraka1 pawanpraka1 removed this from the v0.8.0 milestone May 26, 2020
@pawanpraka1 pawanpraka1 added the good first issue Good for newcomers label May 26, 2020
@ghost
Copy link

ghost commented Jul 21, 2020

Also an issue with deleting snapshots that are in use by clones.

@pawanpraka1
Copy link
Contributor Author

Thanks @chornlgscout for adding the issue related to snapshot deletion when it is in use by clone. Are you already using ZFS-LoclaPV? Could you please let us know your use case and what features you are specifically looking for?

@akhilerm akhilerm linked a pull request Jun 22, 2021 that will close this issue
Open
7 tasks
@sinhaashish
Copy link
Member

There is a PR to close this issue, but that needs some refactoring, its under review.

@Abhinandan-Purkait Abhinandan-Purkait added backlog Will be picked up as a roadmap item. and removed good first issue Good for newcomers labels Jun 6, 2024
@avishnu
Copy link
Member

avishnu commented Sep 24, 2024

The comment on the fix PR #350 (comment) indicates a possible way to successfully delete the volume by promoting the clone on the oldest snapshot. This functionality will be considered as a future enhancement.

@avishnu
Copy link
Member

avishnu commented Sep 24, 2024

Tentatively targeting for v4.2

@avishnu avishnu added this to the v4.2 milestone Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sinhaashish sinhaashish

Labels
backlog Will be picked up as a roadmap item. enhancement Add new functionality to existing feature
Projects
None yet
Milestone
v4.2
Development

Successfully merging a pull request may close this issue.

fix(controller): prevent volume deletion if snapshot exists akhilerm/zfs-localpv
4 participants
@avishnu @pawanpraka1 @sinhaashish @Abhinandan-Purkait