feat(helm): add list of container images #549
Open
+416
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiagolobocastro
force-pushed
the
helm-images
branch
2 times, most recently
from
68e3309 to
6d37394
Compare
niladrih
reviewed
Sep 30, 2024
tiagolobocastro
force-pushed
the
helm-images
branch
3 times, most recently
from
eb4fbbd to
692a86a
Compare
tiagolobocastro
requested review from
niladrih,
Abhinandan-Purkait,
sinhaashish and
abhilashshetty04
tiagolobocastro
force-pushed
the
helm-images
branch
4 times, most recently
from
7f5337c to
27b40f1
Compare
|
bors try |
tryBuild succeeded: |
Abhinandan-Purkait
approved these changes
Feb 4, 2025
| @@ -0,0 +1,29 @@ | |||
| bats/bats:1.8.2 | |||
There was a problem hiding this comment.
Yeah, this keeps an exact list of images
file.yml
Outdated
| @@ -0,0 +1,4 @@ | |||
| a: | |||
There was a problem hiding this comment.
doh, testing :D will delete
Adds a list of container images which are used by the chart. This list is contained in file: charts/images.txt Sometimes the images can't be figured out using templates, and in such cases we need to manually add them. In some cases we might be able to do this using helm variables, which is what we're doing with the localpv provisioner. Github actions have been modified to verify the contents of the images as well as testing them with a live cluster. This is a pretty dumb test that just checks if the live pod images are contained in the images files. Signed-off-by: Tiago Castro <[email protected]>
tiagolobocastro
force-pushed
the
helm-images
branch
from
27b40f1 to
68d83bd
Compare
dsharma-dc
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a list of container images which are used by the chart.
This list is contained in file: charts/images.txt
Sometimes the images can't be figured out using templates, and in such
cases we need to manually add them.
In some cases we might be able to do this using helm variables, which
is what we're doing with the localpv provisioner.
Github actions have been modified to verify the contents of the images
as well as testing them with a live cluster.
This is a pretty dumb test that just checks if the live pod images are
contained in the images files.