Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm chart should read image registry name from global.imageRegistry variable #203

Open
rbcek opened this issue Sep 23, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers
Milestone

Comments

@rbcek
Copy link

rbcek commented Sep 23, 2024

Describe the problem/challenge you have
To use my-image-registry as image registry I have to specify for each setup:

localpv:
  image:
    registry: "my-image-registry/"
helperPod:
  image:
    registry: "my-image-registry/"

Describe the solution you'd like
Usage of global.imageRegistry, which is commonly used would be perfect (without need to append '/' at the end):

global:
  imageRegistry: "my-image-registry"

Anything else you would like to add:
Probably this value should be used as default. Values provided as localpv.image.registry or helperPod.image.registry should overwrite default value.

@niladrih
Copy link
Member

Yep, I see how this could be useful.

@niladrih niladrih self-assigned this Sep 25, 2024
@niladrih niladrih added enhancement New feature or request good first issue Good for newcomers labels Sep 25, 2024
@avishnu avishnu added this to the v4.2 milestone Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants