Skip to content

Commit 0f52386

Browse files
author
kmova
committed
chore(ci): fix the formatting in pr template
Signed-off-by: kmova <[email protected]>
1 parent e7b5eff commit 0f52386

File tree

1 file changed

+35
-6
lines changed

1 file changed

+35
-6
lines changed

.github/pull_request_template.md

Lines changed: 35 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,29 @@
1-
## Pull Request template
2-
Please, go through these steps before you submit a PR.
1+
**Why is this PR required? What issue does it fix?**:
2+
_Fixes #<issue number>_
33

4-
1. This repository follows semantic versioning convention, therefore each PR title/commit message must follow convention: `<type>(<scope>): <subject>`.
4+
**What this PR does?**:
5+
6+
**Does this PR require any upgrade changes?**:
7+
8+
**If the changes in this PR are manually verified, list down the scenarios covered:**:
9+
10+
**Any additional information for your reviewer?** :
11+
_Mention if this PR is part of any design or a continuation of previous PRs_
12+
13+
14+
**Checklist:**
15+
- [ ] PR Title follows the convention of `<type>(<scope>): <subject>`. <!-- See examples below. -->
16+
- [ ] Has the change log section been updated?
17+
- [ ] Commit has unit tests
18+
- [ ] Commit has integration tests
19+
- [ ] (Optional) Does this PR change require updating Helm Chart? If yes, mention the Helm Chart PR #<PR number>
20+
- [ ] (Optional) Are upgrade changes included in this PR? If not, mention the issue/PR to track:
21+
- [ ] (Optional) If documentation changes are required, which issue https://github.com/openebs/website is used to track them:
22+
23+
<!--
24+
PR Title format.
25+
26+
This repository follows semantic versioning convention, therefore each PR title/commit message must follow convention: `<type>(<scope>): <subject>`.
527
`type` is defining if release will be triggering after merging submitted changes, details in [CONTRIBUTING.md](../CONTRIBUTING.md).
628
Most common types are:
729
* `feat` - for new features, not a new feature for build script
@@ -12,6 +34,13 @@ Please, go through these steps before you submit a PR.
1234
* `test` - adding missing tests, refactoring tests; no production code change
1335
* `refactor` - refactoring production code, eg. renaming a variable or function name, there should not be any significant production code changes
1436
15-
IMPORTANT: Please review the [CONTRIBUTING.md](../CONTRIBUTING.md) file for detailed contributing guidelines.
16-
17-
**PLEASE REMOVE THIS TEMPLATE BEFORE SUBMITTING**
37+
Examples:
38+
feat(ha): support faster node failure detection
39+
fix(replica): remove previous replica with same ip
40+
chore(build): upgrade the go version to 1.18
41+
docs(user): add monitoring related user guides
42+
refactor(provisoining): make use of the new context api
43+
test(ut): handling volume deletion failures
44+
test(integation): handling incorrect jiva images
45+
test(e2e): running nfs on jiva volumes
46+
-->

0 commit comments

Comments
 (0)