Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Fix skipped tests that are using test snapshots that convert timestamps to local time #105

Open
ohltyler opened this issue May 6, 2020 · 0 comments
Labels
test fix/enhance testing

Comments

@ohltyler
Copy link
Contributor

ohltyler commented May 6, 2020

Currently, 3 tests are being skipped because they are comparing against test snapshots that contain timestamp conversion logic. Because of this, if the tests are run in a different timezone (example: GitHub runners which run in UTC) the tests will fail, as the raw timestamp in the test is converted to a different local time, and will not match the snapshot's converted local time.

If possible: change the snapshots to only contain the raw timestamp and not the converted value. If that is not possible, then add code in the skipped tests that will test in a way other than comparing to the test snapshot.

@ylwu-amzn ylwu-amzn added the test fix/enhance testing label May 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
test fix/enhance testing
Projects
None yet
Development

No branches or pull requests

2 participants