Improve tests by checking for specific log output

Closes #127.

Author: Michael Sauter

test/tasks/ods-finish_test.go

@@ -4,6 +4,7 @@ import (
 	"fmt"
 	"log"
 	"path/filepath"
+	"strings"
 	"testing"
 	"time"
 
@@ -84,6 +85,11 @@ func TestTaskODSFinish(t *testing.T) {
 					bitbucketClient := tasktesting.BitbucketClientOrFatal(t, ctxt.Clients.KubernetesClientSet, ctxt.Namespace)
 					checkBuildStatus(t, bitbucketClient, ctxt.ODS.GitCommitSHA, bitbucket.BuildStatusSuccessful)
 					checkArtifactsAreInNexus(t, ctxt, nexus.TemporaryRepositoryDefault)
+
+					wantLogMsg := "Artifact coverage.out is already present in Nexus repository"
+					if !strings.Contains(string(ctxt.CollectedLogs), wantLogMsg) {
+						t.Fatalf("Want:\n%s\n\nGot:\n%s", wantLogMsg, string(ctxt.CollectedLogs))
+					}
 				},
 			},
 			"set bitbucket build status to successful and upload artifacts to permanent Nexus repository": {
@@ -109,6 +115,23 @@ func TestTaskODSFinish(t *testing.T) {
 					checkArtifactsAreInNexus(t, ctxt, nexus.PermanentRepositoryDefault)
 				},
 			},
+			"stops gracefully when context cannot be read": {
+				WorkspaceDirMapping: map[string]string{"source": "empty"},
+				PreRunFunc: func(t *testing.T, ctxt *tasktesting.TaskRunContext) {
+					ctxt.Params = map[string]string{
+						"pipeline-run-name":      "foo",
+						"aggregate-tasks-status": "Failed",
+					}
+				},
+				WantRunSuccess: false,
+				PostRunFunc: func(t *testing.T, ctxt *tasktesting.TaskRunContext) {
+					want := "Unable to continue as pipeline context cannot be read"
+
+					if !strings.Contains(string(ctxt.CollectedLogs), want) {
+						t.Fatalf("Want:\n%s\n\nGot:\n%s", want, string(ctxt.CollectedLogs))
+					}
+				},
+			},
 		},
 	)
 }

test/tasks/ods-start_test.go

@@ -4,6 +4,7 @@ import (
 	"fmt"
 	"os"
 	"path/filepath"
+	"strings"
 	"testing"
 
 	"github.com/opendevstack/pipeline/internal/directory"
@@ -181,8 +182,14 @@ func TestTaskODSStart(t *testing.T) {
 					}
 				},
 				WantRunSuccess: false,
-				// TODO: check in post run func that failure is actually due to
-				// missing pipeline run artifact and not due to sth. else.
+				PostRunFunc: func(t *testing.T, ctxt *tasktesting.TaskRunContext) {
+					want := "Pipeline runs with subrepos require a successful pipeline run " +
+						"for all checked out subrepo commits, however no such run was found"
+
+					if !strings.Contains(string(ctxt.CollectedLogs), want) {
+						t.Fatalf("Want:\n%s\n\nGot:\n%s", want, string(ctxt.CollectedLogs))
+					}
+				},
 			},
 			"handles QA stage": {
 				WorkspaceDirMapping: map[string]string{"source": "hello-world-app"},