Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get rid of upstream code in __main__.py #10

Open
dtrifiro opened this issue Jun 18, 2024 · 3 comments
Open

get rid of upstream code in __main__.py #10

dtrifiro opened this issue Jun 18, 2024 · 3 comments
Labels
kind/enhancement New feature or request

Comments

@dtrifiro
Copy link
Contributor

Once vllm-project/vllm#5090 (review) is merged, we should be able to use the same engine to spin up both http and grpc servers without duplicating upstream code

@dtrifiro dtrifiro added the kind/enhancement New feature or request label Jun 18, 2024
@prashantgupta24 prashantgupta24 self-assigned this Jun 18, 2024
@dtrifiro
Copy link
Contributor Author

@prashantgupta24 the above has been merged, we can move on and remove the upstream code from __main__.py

@prashantgupta24
Copy link
Contributor

Uhh I'm still reading up on asyncio, but the problem that I'm facing right now is this:

https://github.com/vllm-project/vllm/blob/main/vllm/entrypoints/openai/api_server.py#L236-L239
Based on these lines, the run_server function uses asyncio.get_running_loop() to get the event_loop coming from our __main__.py and tries to do event_loop.run_until_complete which is incorrect.

With my limited understanding, this kind of makes me think we won't be able to use asyncio's event loops to start the http_server unless we make changes to upstream?

@dtrifiro
Copy link
Contributor Author

Yeah, that's correct 😔

@prashantgupta24 prashantgupta24 removed their assignment Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants