[Feature Request]: use sha256 digest values of images in odh-manifests non-master branch #1470
Labels
community
infrastructure
Anything non feature/* related that improves general working of the Dashboard
kind/enhancement
New functionality request (existing augments or new additions)
priority/high
Important issue that needs to be resolved asap. Releases should not have too many of these.
Feature description
To be compatible with on-prem restricted network environment installs, image references need to be in sha256 digest format, not tag format. In any master or version branch of odh-manifests.
This applies, for odh dashboard recipes, mostly to the images section in kustomization.yaml
https://github.com/opendatahub-io/odh-manifests/blob/v1.7/odh-dashboard/base/kustomization.yaml#L25
i.e. instead of
use the following format, yaml comment suggested for readability for humans :-)
digests are for illustration only.
@Jooho what do you think? Would a github action to scan for all images sections in odh manifests be the best way to handle this, updating to the digest-format, or should we leave this to the maintainers?
Also, sometimes, there are also program args, like for odh notebook controller, that need to be in sha256 digest format, like at https://github.com/opendatahub-io/odh-manifests/blob/master/odh-notebook-controller/odh-notebook-controller/manager/manager.yaml#L28 which are still in tag format.
Describe alternatives you've considered
There is no way around digest format for on-prem and exact references to images.
Anything else?
No response
The text was updated successfully, but these errors were encountered: