Skip to content

Commit 25d21af

Browse files
authored
Merge pull request #687 from HumairAK/fix_default_envoy_route
fix default envoy route behavior
2 parents 8339af5 + 67fd529 commit 25d21af

File tree

3 files changed

+7
-1
lines changed

3 files changed

+7
-1
lines changed

controllers/dspipeline_params.go

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -504,6 +504,9 @@ func (p *DSPAParams) SetupMLMD(dsp *dspa.DataSciencePipelinesApplication, log lo
504504
log.Info("MLMD not specified, but is a required component for V2 Pipelines. Including MLMD with default specs.")
505505
p.MLMD = &dspa.MLMD{
506506
Deploy: true,
507+
Envoy: &dspa.Envoy{
508+
DeployRoute: true,
509+
},
507510
}
508511
} else if !p.MLMD.Deploy {
509512
return fmt.Errorf(MlmdIsRequiredInV2Msg)
@@ -515,7 +518,8 @@ func (p *DSPAParams) SetupMLMD(dsp *dspa.DataSciencePipelinesApplication, log lo
515518

516519
if p.MLMD.Envoy == nil {
517520
p.MLMD.Envoy = &dspa.Envoy{
518-
Image: config.GetStringConfigWithDefault(MlmdEnvoyImagePath, config.DefaultImageValue),
521+
Image: config.GetStringConfigWithDefault(MlmdEnvoyImagePath, config.DefaultImageValue),
522+
DeployRoute: true,
519523
}
520524
}
521525
if p.MLMD.GRPC == nil {

tests/resources/dspa-external-lite.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,7 @@ spec:
4141
deploy: true
4242
envoy:
4343
image: quay.io/maistra/proxyv2-ubi8:2.5.0
44+
deployRoute: false
4445
resources:
4546
limits:
4647
cpu: 20m

tests/resources/dspa-lite.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,7 @@ spec:
4141
deploy: true
4242
envoy:
4343
image: quay.io/maistra/proxyv2-ubi8:2.5.0
44+
deployRoute: false
4445
resources:
4546
limits:
4647
cpu: 20m

0 commit comments

Comments
 (0)