Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coordinate Transform Issues #525

Open
omad opened this issue Nov 14, 2022 · 0 comments
Open

Coordinate Transform Issues #525

omad opened this issue Nov 14, 2022 · 0 comments
Assignees

Comments

@omad
Copy link
Member

omad commented Nov 14, 2022

I've just put in place two work-arounds due to failing coordinate transform tests.

The first is in odc.algo for choosing a Transform Path, which is choosing a different transform depending on something like the GDAL/Proj version.

The other is in odc.apps.dc_tools during the STAC transform. The code is for transform Geographic coordinates into a Projected Coordinate system, and (IMO choosing a bad rounding value), which is resulting in off by 1 values in the transform. I've wrapped these coordinate values in pytest.approx with an epsilon of 1.

I'm not happy with either of these, and the root causes should be addressed and understood.

From #524

I think the STAC geometry transform is from #93, which did include some improvements, but I don't think addressed all the potential problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants