Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compute_count broken in rust implementation of geomedian? #8

Open
maawoo opened this issue Apr 26, 2024 · 2 comments
Open

compute_count broken in rust implementation of geomedian? #8

maawoo opened this issue Apr 26, 2024 · 2 comments
Assignees

Comments

@maawoo
Copy link

maawoo commented Apr 26, 2024

Hi all,
first off, great job on the rust implementation of geomedian. It's impressively fast! 🙂
I did a quick test between the implementation in version 0.2.4 of the package and the add-rust-geomedian-impl branch. Shape of my test dataset is (time: 5, y: 1311, x: 3704) and the average absolute differences for each variable are quite small, however, the count variable stands out and has not been computed as expected (see second screenshot):

image

image

Is this a known issue because the implementation has not been finished yet?

@maawoo
Copy link
Author

maawoo commented Apr 27, 2024

In comparison to the new version of the calculation, the old version seems to be more performant and works:

image
image

I can do a PR if there are no other plans for improvement or ideas for fixing the newer version.

@robbibt
Copy link
Contributor

robbibt commented Apr 28, 2024

Ping @omad

@omad omad self-assigned this May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants