Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pre-commit to make it easier for developers to apply linting before push #114

Open
whatnick opened this issue Jul 12, 2021 · 0 comments
Open

Add pre-commit to make it easier for developers to apply linting before push #114

whatnick opened this issue Jul 12, 2021 · 0 comments
Assignees
@whatnick
Labels
enhancement New feature or request

Comments

@whatnick
Copy link
Member

Expected behaviour

Code that arrives into github remote passes linting locally.

Actual behaviour

Currently developers see linting fail in CI since there is no git pre-commit hook to make this easier. Apply PyCQA practices through a pre-commit hook that is the same as the one in CI.

Steps to reproduce the behaviour

Failed linting runs in CI
@whatnick whatnick added the enhancement New feature or request label Jul 12, 2021
@whatnick whatnick self-assigned this Jul 12, 2021
whatnick added a commit to whatnick/datacube-wps that referenced this issue Jul 12, 2021
@whatnick
opendatacube#114 Initial pre-commit hook
04ee047
uchchwhash pushed a commit that referenced this issue Jul 12, 2021
@whatnick @uchchwhash
#114 Initial pre-commit hook
6fe5241
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@whatnick whatnick

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@whatnick