-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update core docker image to latest osgeo/gdal images #1471
Comments
This sounds like a very minor proposed change. An alternative would be to switch to a micromamba image (i.e., let condaforge handle the binary interdependencies). Perhaps this could be done in such a way as to also be a test of the ODC conda recipe? |
Only at the price of either losing our existing test of pure pip dependency resolution - or maintaining two separate pip and conda based docker images. The former would be a deal breaker IMO, but maintaining two docker images for the added environmental test coverage might be worth the effort. Having said that, we do have minimal "smoke tests" for testing the conda recipe in different environments. |
I'm against moving to a conda-based Docker environment. In short, conda is a big complex system and is quite opinionated. Using the osgeo/gdal Docker image as a base is simply using a reliable, fresh install of GDAL and is the pattern used for most of our ODC tools... we should be testing against that environment. Moving the source of the base container is a very minor thing, as @benjimin says. |
Expected behaviour
Default core docker build uses latest
osgeo/gdal
ubuntu as the base image.Actual behaviour
An old
osgeo/gdal
image is loaded from DockerHub -osgeo/gdal
has migrated to Github containers (ghcr.io)See https://github.com/OSGeo/gdal/
The text was updated successfully, but these errors were encountered: