Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URL regex in schema blocks valid urls and allows invalid urls #35

Open
hidde-jan opened this issue May 24, 2024 · 0 comments
Open

URL regex in schema blocks valid urls and allows invalid urls #35

hidde-jan opened this issue May 24, 2024 · 0 comments

Comments

@hidde-jan
Copy link

hidde-jan commented May 24, 2024

The URL regex is both too restrictive and too lenient.

It does not consider domain names without a TLD valid, which are used in both docker and kubernetes, e.g. http://my-internal-api/some-path. It also doesn't allow an URL that contains an ip: http://127.0.0.1:3000 or http://localhost:3000. Both examples are very common, especially during development.

At the same time, the following url is considered valid: http://.com/

My suggestion is choose a different regex.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant