Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roaster agent-target type doesn't appear to match the CACAO spec #13

Open
dlemire60 opened this issue Mar 25, 2024 · 0 comments
Open

Roaster agent-target type doesn't appear to match the CACAO spec #13

dlemire60 opened this issue Mar 25, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@dlemire60
Copy link

dlemire60 commented Mar 25, 2024

I played some more and the way Roaster creates agent definitions doesn't seem to match what's in the spec. I created a net-address agent in Roaster:

"agent_definitions": {
  "agent-target--f24ee4da-68d9-49ea-ab06-39075e73106b": {
    "type": "net-address",

But the example in the spec (section 7.10) looks rather different:

"agent_definitions": {
  "net-address--6f6f9814-5982-4322-9a9c-0ef25d33ef2a": {
    "type": "net-address",

In the spec, the object's identifier starts with the type of agent, rather than the generic agent-target. If I search the text for "agent-target", that's the name for the object type but I never see it used as a literal value in the JSON examples.

And since that type is an open-vocab, a proper fix should handle user-defined agent types as well:

"agent_definitions": {
  "openc2-mqtt--6f6f9814-5982-4322-9a9c-0ef25d33ef2a": {
    "type": "openc2-mqtt",
@mateusdz mateusdz added the bug Something isn't working label Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants