-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug: Exchange rate not working #5
Comments
There is no currency calculation being performed in OpenCost, we're simply recording what's exposed in the API for the value of the cost and recording it. The currency drop-down in the UI is cosmetic and there is no currency associated with the recorded values in Prometheus. I can see how this is an issue if you were doing multiple clusters across multiple currencies and consolidating them to a single database, but that's currently outside our primary scope. That said, is Cost Explorer showing values different from what we're displaying? That would be an interesting bug, since we're getting costs from their pricing API but it's showing you something different. What currency are you paying your bill in vs. what are you looking at in their UI? I'm not sure how we'd tackle that if it's an issue, but please report back. |
If you did tie into the exchange rate would this help? https://exchangeratesapi.io/ From a cosmetic principle would it be a nice idea to use currency symbols? |
I really feel like we need this feature |
Well done me know one else, Hope you have a very lovely Christmas |
This is could be very important If the the AWS business model |
Currency in opencost is currently only for display; whatever comes out of the pricing URL will be what's in the application, from the time at which it was selected going forward. An actual conversion module would be interesting though, I think we could take a PR there. |
As I understand default currency, not changeable, is USD and opencost team is avoiding adding any thirdparty dependency on currency conversion api. But on changing currency, a simple input box asking the currency conversion rate from user,(with basic validation of input) and use it to calculate cost. This way no hard dependency on thirdparty conversion rate api and easy fix for a critical issue. |
Would support a PR for conversion on the frontend! |
Describe the bug
Exchange rate doesn't appear to be working.
To Reproduce
Steps to reproduce the behavior:
Check the Opencost UI dashboard.
In this instance i am selecting TTD
When i switch to THB
The price is the same.
I now compare that to the AWS Cost Explorer and i don't get a selection for currency.
Is AWS plugged into the exchange. Profound right?
The text was updated successfully, but these errors were encountered: