Merge pull request #223 from Mashimiao/validate-add-hard-soft-limit-check

Mrunal Patel · web-flow · commit e129a67abe52 · 2016-10-03T12:36:25.000-07:00
validate: add hard and soft limit check for rlimit
diff --git a/cmd/oci-runtime-tool/validate.go b/cmd/oci-runtime-tool/validate.go
@@ -234,6 +234,9 @@ func checkProcess(spec rspec.Spec, rootfs string, hostCheck bool) (msgs []string
 		if !rlimitValid(process.Rlimits[index].Type) {
 			msgs = append(msgs, fmt.Sprintf("rlimit type %q is invalid.", process.Rlimits[index].Type))
 		}
+		if process.Rlimits[index].Hard < process.Rlimits[index].Soft {
+			msgs = append(msgs, fmt.Sprintf("hard limit of rlimit %s should not be less than soft limit.", process.Rlimits[index].Type))
+		}
 	}
 
 	if len(process.ApparmorProfile) > 0 {

Original file line number	Diff line number	Diff line change
`@@ -234,6 +234,9 @@ func checkProcess(spec rspec.Spec, rootfs string, hostCheck bool) (msgs []string`
`234`	`234`	`if !rlimitValid(process.Rlimits[index].Type) {`
`235`	`235`	`msgs = append(msgs, fmt.Sprintf("rlimit type %q is invalid.", process.Rlimits[index].Type))`
`236`	`236`	`}`
	`237`	`+ if process.Rlimits[index].Hard < process.Rlimits[index].Soft {`
	`238`	`+ msgs = append(msgs, fmt.Sprintf("hard limit of rlimit %s should not be less than soft limit.", process.Rlimits[index].Type))`
	`239`	`+ }`
`237`	`240`	`}`
`238`	`241`
`239`	`242`	`if len(process.ApparmorProfile) > 0 {`