Modernize the code for Go 1.24

Mostly done by

	modernize -fix -test ./...

with some minor manual edits on top.

Signed-off-by: Kir Kolyshkin <[email protected]>

Author: kolyshkin

devices/devicefilter_test.go

@@ -9,7 +9,7 @@ import (
 
 func hash(s, comm string) string {
 	var res []string
-	for _, l := range strings.Split(s, "\n") {
+	for l := range strings.SplitSeq(s, "\n") {
 		trimmed := strings.TrimSpace(l)
 		if trimmed == "" || strings.HasPrefix(trimmed, comm) {
 			continue

devices/devices_emulator_test.go

@@ -202,7 +202,6 @@ c 10:200 rwm`,
 	}
 
 	for _, test := range tests {
-		test := test // capture range variable
 		t.Run(test.name, func(t *testing.T) {
 			list := bytes.NewBufferString(test.list)
 			emu, err := emulatorFromList(list)
@@ -741,7 +740,6 @@ func testDeviceEmulatorApply(t *testing.T, baseDefaultAllow bool) {
 	}
 
 	for _, test := range tests {
-		test := test
 		t.Run(test.name, func(t *testing.T) {
 			err := test.base.Apply(test.rule)
 			if err != nil && test.expected != nil {
@@ -1058,7 +1056,6 @@ func testDeviceEmulatorTransition(t *testing.T, sourceDefaultAllow bool) {
 	}
 
 	for _, test := range tests {
-		test := test
 		t.Run(test.name, func(t *testing.T) {
 			// If we are in black-list mode, we need to prepend the relevant
 			// clear-all rule (the expected rule lists are written with
@@ -1130,7 +1127,7 @@ c 10:200 rwm`
 
 	var r *deviceRule
 	var err error
-	for i := 0; i < b.N; i++ {
+	for b.Loop() {
 		s := bufio.NewScanner(strings.NewReader(list))
 		for s.Scan() {
 			line := s.Text()

devices/systemd_test.go

@@ -256,7 +256,7 @@ func TestFindDeviceGroup(t *testing.T) {
 }
 
 func BenchmarkFindDeviceGroup(b *testing.B) {
-	for i := 0; i < b.N; i++ {
+	for b.Loop() {
 		if err := testFindDeviceGroup(); err != nil {
 			b.Fatal(err)
 		}

file_test.go

@@ -82,8 +82,7 @@ func BenchmarkWriteFile(b *testing.B) {
 		"\n\n\n\n\n\n\n\n",
 	}
 
-	b.ResetTimer()
-	for i := 0; i < b.N; i++ {
+	for b.Loop() {
 		for _, val := range tc {
 			if err := WriteFileByLine(dir, "file", val); err != nil {
 				b.Fatal(err)

fs/cpuacct.go

@@ -105,7 +105,7 @@ func getPercpuUsage(path string) ([]uint64, error) {
 	if err != nil {
 		return percpuUsage, err
 	}
-	for _, value := range strings.Fields(data) {
+	for value := range strings.FieldsSeq(data) {
 		value, err := strconv.ParseUint(value, 10, 64)
 		if err != nil {
 			return percpuUsage, &parseError{Path: path, File: file, Err: err}

fs/cpuacct_test.go

@@ -102,8 +102,7 @@ func BenchmarkGetCpuUsageBreakdown(b *testing.B) {
 		"cpuacct.stat": cpuAcctStatContents,
 	})
 
-	b.ResetTimer()
-	for i := 0; i < b.N; i++ {
+	for b.Loop() {
 		_, _, err := getCpuUsageBreakdown(path)
 		if err != nil {
 			b.Fatal(err)

fs/cpuset.go

@@ -82,7 +82,7 @@ func getCpusetStat(path string, file string) ([]uint16, error) {
 		return extracted, &parseError{Path: path, File: file, Err: errors.New("empty file")}
 	}
 
-	for _, s := range strings.Split(fileContent, ",") {
+	for s := range strings.SplitSeq(fileContent, ",") {
 		fromStr, toStr, ok := strings.Cut(s, "-")
 		if ok {
 			from, err := strconv.ParseUint(fromStr, 10, 16)

fs/fs_test.go

@@ -36,8 +36,7 @@ func BenchmarkGetStats(b *testing.B) {
 
 	var st *cgroups.Stats
 
-	b.ResetTimer()
-	for i := 0; i < b.N; i++ {
+	for b.Loop() {
 		st, err = m.GetStats()
 		if err != nil {
 			b.Fatal(err)

fs2/create.go

@@ -28,7 +28,7 @@ func needAnyControllers(r *cgroups.Resources) (bool, error) {
 		return false, err
 	}
 	avail := make(map[string]struct{})
-	for _, ctr := range strings.Fields(content) {
+	for ctr := range strings.FieldsSeq(content) {
 		avail[ctr] = struct{}{}
 	}
 
@@ -137,8 +137,7 @@ func CreateCgroupPath(path string, c *cgroups.Cgroup) (Err error) {
 		if i < len(elements)-1 {
 			if err := cgroups.WriteFile(current, cgStCtlFile, res); err != nil {
 				// try write one by one
-				allCtrs := strings.Split(res, " ")
-				for _, ctr := range allCtrs {
+				for ctr := range strings.SplitSeq(res, " ") {
 					_ = cgroups.WriteFile(current, cgStCtlFile, ctr)
 				}
 			}

fscommon/utils.go

@@ -82,8 +82,7 @@ func GetValueByKey(path, file, key string) (uint64, error) {
 	}
 
 	key += " "
-	lines := strings.Split(content, "\n")
-	for _, line := range lines {
+	for line := range strings.SplitSeq(content, "\n") {
 		v, ok := strings.CutPrefix(line, key)
 		if ok {
 			val, err := ParseUint(v, 10, 64)