Sample output violates the spec #12
Comments
|
You are absolutely correct, and this was also discovered recently in writing the rust api. I'll fix this and add the schema validator check for the examples here (which is how the rust one was highlighted) |
actually now i see this was already in #5 |
mimir-d
added a commit
that referenced
this issue
Oct 13, 2024
- fix extension example since it was outputting a string extension which is invalid, per the spec (also a test) - fix the typing to disallow primitive types for extension content - added scripts/check.sh for easier validation before github actions get to run on any PRs - fixes #5, #12 Signed-off-by: mimir-d <[email protected]>
|
fixed in #14 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
One of the examples in the sample output violates the spec IMO. https://github.com/opencomputeproject/ocp-diag-core-python/blob/dev/examples/sample_output.txt#L59 shows that the extension content can be an arbitrary string value, but the spec says that this must be a JSON object.
Can we get clarification on whether this is valid results output, and/or update the example to show valid output?
The text was updated successfully, but these errors were encountered: