Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support new ThermalSubsystem, PowerSubsystem, Fan, PowerSupply #25

Open
gtmills opened this issue May 18, 2021 · 6 comments
Open

Support new ThermalSubsystem, PowerSubsystem, Fan, PowerSupply #25

gtmills opened this issue May 18, 2021 · 6 comments
Assignees
Labels
Fixed The fix is in a pull request profile-hw_baseline

Comments

@gtmills
Copy link

gtmills commented May 18, 2021

Redfish in 2020.4 added PowerSubsystem, ThermalSubsystem, Fan, PowerSupply, PowerSupplyMetrics

https://www.dmtf.org/sites/default/files/Redfish_Release_2020.4_Overview.pdf

These are a huge improvement over the now deprecated Power / Thermal schemas.

Probably need to change the profile to allow either the old Power / Thermal schemas or the new schemas.

@jcleung5549 jcleung5549 self-assigned this Feb 22, 2022
@jcleung5549 jcleung5549 added the Discussion Required Issue/Resolution requires discussion label Mar 14, 2022
@jcleung5549
Copy link
Contributor

How does the OCP HW Mgmt community want to transition to the new power/thermal model?

@gtmills
Copy link
Author

gtmills commented Jun 30, 2022

Could you support either the old or the new for a period of time?
Could you require both for a period of time?

@jcleung5549
Copy link
Contributor

Approval by WS to add new resources and deprecated the old. For now support both old and new.
Revision policy - 1.x will have old and new. When old is dropped, the major revision is changed (e.g. 2.x)

@jcleung5549 jcleung5549 added Approved Approved - can be assigned and removed Discussion Required Issue/Resolution requires discussion labels Jun 2, 2023
@jcleung5549
Copy link
Contributor

Draft of the Usage Guide for the Baseline Profile (v1.1.0) - https://drive.google.com/file/d/1gVaEInlaMZ6Z9phw0HYJXUC2cn3EnrR3

Questions that need discussion:

  1. The PowerSupply is accessible via two paths. Should both be prescribed?
/redfish/v1/Chassis/{ChassisId}/PowerSubsystem/PowerSupplies/{PowerSupplyId}
/redfish/v1/PowerEquipment/PowerShelves/{PowerDistributionId}/PowerSupplies/{PowerSupplyId}
  1. There are three sensors for temperature: AmbientTemp, IntakeTemp and ExhaustTemp. Should the profile prescribe one?
  2. For power usage, can the profile prescribe the "TotalPower" resource member of Sensors (collection)?
  3. For power limit, can the profile prescribe the "PowerLimit' resource member of Controls (colllection)?
  4. Is it correct to state that power redundancy modelling was not available with the ./Power model?

@jcleung5549 jcleung5549 added the Discussion Required Issue/Resolution requires discussion label Jun 5, 2023
@jcleung5549
Copy link
Contributor

Profile WS meeting discussion

  1. The PowerEquipment path has been deprecated
  2. The ThermalSubsystem/ThermalMetrics should be used
  3. No objections to prescribing named collection members
  4. No objections
  5. Yes, it is available, but don't need to describe since the intent to prescribe the newer model.

@jcleung5549 jcleung5549 removed the Discussion Required Issue/Resolution requires discussion label Dec 5, 2023
@jcleung5549 jcleung5549 added Fixed The fix is in a pull request and removed Approved Approved - can be assigned labels Feb 6, 2024
@jcleung5549
Copy link
Contributor

Baseline v1.1 merged. Await HW Mgmt Project to release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fixed The fix is in a pull request profile-hw_baseline
Projects
None yet
Development

No branches or pull requests

2 participants