-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move SerialConsole to ComputerSystem #23
Labels
Comments
Change profile to have SerialConsole either in Manages or ComputerSystem. |
bradbishop
pushed a commit
to openbmc/bmcweb
that referenced
this issue
Jun 27, 2021
2020.3 moved SerialConsole and GraphicalConsole to ComputerSystem. More information can be found on: http://www.dmtf.org/sites/default/files/Redfish_Release_2020.3_Overview.pdf These Consoles are readonly properties and were recently added. Figured no clients are looking for them, but the OCP profile does require SerialConsole so left them in Manager. The OCP profile has not released a new version in 18 months. Filed the following issue with the profile: opencomputeproject/HWMgmt-OCP-Profiles#23 After we remove from manager the following validator warning will go away: "SerialConsole: The given property is deprecated by revision: This property has been deprecated in favor of the SerialConsole property in the ComputerSystem resource." Tested: Passes Validator. "GraphicalConsole": { "ConnectTypesSupported": [ "KVMIP" ], "MaxConcurrentSessions": 4, "ServiceEnabled": true }, "SerialConsole": { "IPMI": { "ServiceEnabled": true }, "MaxConcurrentSessions": 15, "SSH": { "HotKeySequenceDisplay": "Press ~. to exit console", "Port": 2200, "ServiceEnabled": true } }, Change-Id: I1cc41c0da67e0d4123678f645828dfe1856d7a8f Signed-off-by: Gunnar Mills <[email protected]> Signed-off-by: Abhishek Patel <[email protected]>
bradbishop
pushed a commit
to openbmc/bmcweb
that referenced
this issue
Nov 15, 2024
In 2020, the OCP Profile moved to accept SerialConsole in either Manager or System.[1] That was the reason of still having this code. SerialConsole was deprecated in Manager v1_10_0. v1_19_2 is the latest Manager version[2]. SerialConsole was added to System in 2021[3]. In 2023, SerialConsole was enhanced to get the status not just hardcode to enabled. [1]: opencomputeproject/HWMgmt-OCP-Profiles#23 [2]: https://redfish.dmtf.org/schemas/v1/Manager.v1_19_2.json [3]: 0e8ac5e [4]: 5c3e927 Tested: Covered by automated tests. Change-Id: I0a95e9215d4aa4626a3da75c989cb7d5eaf94be1 Signed-off-by: Gunnar Mills <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Also in 2020.3 Redfish moved SerialConsole to the ComputerSystem resource.
More information can be found at http://www.dmtf.org/sites/default/files/Redfish_Release_2020.3_Overview.pdf (slide 12)
The text was updated successfully, but these errors were encountered: