Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contributors.svg is out of date of many months #59

Closed
Arthur-Milchior opened this issue Jul 10, 2022 · 3 comments
Closed

contributors.svg is out of date of many months #59

Arthur-Milchior opened this issue Jul 10, 2022 · 3 comments
Labels
bug Something isn't working

Comments

@Arthur-Milchior
Copy link

Arthur-Milchior commented Jul 10, 2022

Describe the bug

The contributors.svg image don't get updated

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://opencollective.com/ankidroid/contributors.svg
  2. Counts the number of contributors listed (243)
  3. Look at https://github.com/ankidroid/Anki-Android
  4. Look at number of contributors (312)
  5. Look at the image source code.

Expected behavior

Both numbers should be equal. Or at least relatively close. After all, caching the data and being out of date from a few hours or days would be entirely acceptable for any of our purpose. Being months old, I suspect it's not the expected behavior

If a user action is required to update the cache, I'd consider making sure it can be easily found it from either the source code or the link at the end of the image. Neither seems to hold.

Also, I'd expect the indentation to be the same for every contributors. But the first one is more indented for some reason. But this one is far less important as an issue

Screenshots

From github: 2022-07-10-194840_290x124_scrot

From your image: 2022-07-10-194832_841x210_scrot

Prefix of the source code of your image: 2022-07-10-195007_1020x45_scrot

Desktop (please complete the following information):

  • OS: Ubuntu
  • Browser Chrome
  • Version: 103.0.5060.53 (Official Build) (64-bit)

Additional context

I have wondered whether you only considered people who contributed to the open collective, but I doubted it, because I see we have 2543 donors (I honestly have a hard time believing it, even if it's only .1% of our user base. Thanks for allowing it). However, I saw at the start of the images some really active past contributors who have not been present with us for years and I doubt they interacted with the open Collective

Triage Template (core team only)

This template is for members of the team to triage for prioritisation. For more guidance see https://www.loom.com/share/369ab467fbc64dec848085d38ff57ca0:

P1 high frequency, high impact
P2 low frequency, high impact
P3 high frequency, low impact
P4 low frequency, low impact

Examples of high impact - a problem affects users during an essential process (expenses and payments > onboarding and registration > contributing) with no workaround.

High frequency - >10% of users affected (measured as a proportion of total potential users for this case).

@Arthur-Milchior Arthur-Milchior added the bug Something isn't working label Jul 10, 2022
@znarf znarf transferred this issue from opencollective/opencollective Jul 10, 2022
@znarf
Copy link
Member

znarf commented Jul 10, 2022

It's likely that the Redis cache was stuck due to an old version of the codebase from a year ago. I just flushed the cache for ankidroid. It should be better, maybe only in a few hours due to others layers of cache on the CDN side.

@Arthur-Milchior
Copy link
Author

Thank you. Appreciated.
Out of curiosity, did you just flush out for our project? Since it's usually not something checked very often, I could have imagined that other team have the same problems and may have missed it. So I'd humbly suggest checking whether other cache has not been updated since this old version of the codebase (admittedly, I assume some teams may have not been updated because they became inactive, I've no idea how to arrange that.)

By the way, thanks for letting us pull this image from your server. It's nice to have on our github thank's note

@Betree
Copy link
Member

Betree commented Dec 6, 2024

Closing as it seems resolved.

@Betree Betree closed this as completed Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants