Skip to content
This repository has been archived by the owner on Sep 7, 2023. It is now read-only.

Format docstrings so they pass pydocstyle's criteria #81

Open
JackKelly opened this issue Sep 16, 2021 · 8 comments
Open

Format docstrings so they pass pydocstyle's criteria #81

JackKelly opened this issue Sep 16, 2021 · 8 comments
Labels
documentation Improvements or additions to documentation enhancement New feature or request good first issue Good for newcomers

Comments

@JackKelly
Copy link
Member

Detailed Description

We plan to use pydocstyle to automatically check that our docstrings conform to a standard format. It would be amazing to have help tweaking our existing docstrings to conform!

pydocstyle's list of criteria is here: http://www.pydocstyle.org/en/stable/error_codes.html

Here's the Pull Request (and discussion) about enabling pydocstyle for nowcasting_utils: openclimatefix/nowcasting_utils#23

@JackKelly JackKelly added documentation Improvements or additions to documentation enhancement New feature or request good first issue Good for newcomers labels Sep 16, 2021
@mfrasco
Copy link

mfrasco commented Oct 11, 2021

Hi! I'm a data scientist living in Seattle, USA. I am looking to get more involved in open source projects tackling the climate crisis. I think that your project is really interesting, and I'd love to help you by working on this issue (and perhaps the similar issues in other repos). Would you be open to this contribution from me?

@JackKelly
Copy link
Member Author

Hey! Thanks so much for getting in touch! We'd definitely welcome your contributions!

On this specific issue, I should check something: @jacobbieker & @peterdudfield are we still planning to use pydocstyle; and do predict_pv_yield's docstrings still need to be updated?!

@peterdudfield
Copy link
Contributor

peterdudfield commented Oct 11, 2021

Hi @mfrasco, thanks for getting involved.

@JackKelly yes we are still planning to use pydocstyle. This has been implemented for Nowcasting_dataset and Nowcasting_utils. And yes 'predict_pv_yield' does need updating

It looks like work on a big 'joint' model (openclimatefix/satflow#101) has started in Satflow. Perhaps it would be good to add 'pydocstyle' to this repo first. I mention this so that the work for this issue is most useful.

Thoughts?

@JackKelly
Copy link
Member Author

Sure, sounds good! @mfrasco would you be happy to work on openclimatefix/satflow#97? (Which is still formatting docstrings; but in the SatFlow repo!)

@mfrasco
Copy link

mfrasco commented Oct 12, 2021

Definitely! I can do that.

@JackKelly
Copy link
Member Author

Fantastic, thank you!

@peterdudfield
Copy link
Contributor

Thanks very much @mfrasco

@jacobbieker
Copy link
Member

Thanks @mfrasco! I can also help with a lot of the SatFlow stuff, if any of it is confusing!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Improvements or additions to documentation enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants