Skip to content
This repository has been archived by the owner on Sep 7, 2023. It is now read-only.

Try 2d, 3d CNN before attention #63

Open
JackKelly opened this issue Jul 26, 2021 · 6 comments
Open

Try 2d, 3d CNN before attention #63

JackKelly opened this issue Jul 26, 2021 · 6 comments

Comments

@JackKelly
Copy link
Member

JackKelly commented Jul 26, 2021

related: #35

3D cnn: sees two timesteps at once

@JackKelly JackKelly changed the title Try CNN before attention Try 2d, 3d CNN before attention Jul 27, 2021
@peterdudfield
Copy link
Contributor

https://github.com/openclimatefix/predict_pv_yield/blob/issue/85-perciever-nwp/predict_pv_yield/models/perceiver/perceiver_conv3d_nwp_sat.py

This model does now

@JackKelly
Copy link
Member Author

JackKelly commented Oct 12, 2021

Nice! How well does the new model perform?! :)

@peterdudfield
Copy link
Contributor

I dont have a direct comparision to running it without the cnn.

results: https://github.com/openclimatefix/predict_pv_yield/blob/issue/85-perciever-nwp/experiments/2021-09/2021-09-28/experiments.txt

@JackKelly
Copy link
Member Author

Cool beans. No rush, but it might be nice to have a direct comparison, so we can get a feel for whether it's useful to place a CNN before the attention. What do you think?

@peterdudfield
Copy link
Contributor

yea, I think it would be a useful to do. Could also see if 01, ... N layers of CNN are useful?

@JackKelly
Copy link
Member Author

sounds great!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants