Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Go mod support #11

Open
someone1 opened this issue Oct 25, 2018 · 2 comments · May be fixed by #12
Open

Go mod support #11

someone1 opened this issue Oct 25, 2018 · 2 comments · May be fixed by #12

Comments

@someone1
Copy link

As-is, using go mod will fail building this package since it points to v2.0.0 by default of this repository which is the fork of gomodule/redigo. Possibly tagging a new version (e.g. v2.1.0 or something) would fix this. Alternatively, adding full support of go mod would be welcome!
@odeke-em
Copy link
Member

Thanks for filing this @someone1! This package at some point is planned to be merged upstream with gomodule/redigo and I've made the original authors aware of it.

In the meantime sure, I'll add support for go mod.

@odeke-em
Copy link
Member

I've tagged v2.0.1 https://github.com/opencensus-integrations/redigo/releases/tag/v2.0.1

odeke-em added a commit that referenced this issue Oct 25, 2018
@odeke-em
Add go.mod file
e1b934d 
Go mod initiated

Fixes #11
@odeke-em odeke-em linked a pull request Oct 25, 2018 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add go.mod file opencensus-integrations/redigo
2 participants
@someone1 @odeke-em