Incorrect config file crash the service

[drakedog2008]

I accidentally forgot the Name property for one E-M config file but was surprised to find the whole service was crashed and the bmc is accessible because the network service depends on the E-M.

It makes think if we can ignore the ill-formed single config and continue to processed the health ones. It would make the system more robust.

[drakedog2008]

Attached the log:

entity-manager: /usr/include/nlohmann/json.hpp:2135: const nlohmann::json_abi_v3_11_2::basic_json<ObjectType, ArrayType, StringType, BooleanType, NumberIntegerType, NumberUnsignedType, NumberFloatType, AllocatorType, JSONSerializer, BinaryType>::value_type& nlohmann::json_abi_v3_11_2::basic_json<ObjectType, ArrayType, StringType, BooleanType, NumberIntegerType, NumberUnsignedType, NumberFloatType, AllocatorType, JSONSerializer, BinaryType>::operator[](const typename object_t::key_type&) const [with ObjectType = std::map; ArrayType = std::vector; StringType = std::__cxx11::basic_string; BooleanType = bool; NumberIntegerType = long long int; NumberUnsignedType = long long unsigned int; NumberFloatType = double; AllocatorType = std::allocator; JSONSerializer = nlohmann::json_abi_v3_11_2::adl_serializer; BinaryType = std::vector; const_reference = const nlohmann::json_abi_v3_11_2::basic_json<>&; typename object_t::key_type = std::__cxx11::basic_string; object_t = std::map<std::__cxx11::basic_string, nlohmann::json_abi_v3_11_2::basic_json<>, std::less, std::allocator<std::pair<const std::__cxx11::basic_string, nlohmann::json_abi_v3_11_2::basic_json<> > > >]: Assertion `it != m_value.object->end()' failed.

[pointbazaar]

Patch for the runtime schema validation https://gerrit.openbmc.org/c/openbmc/entity-manager/+/81472/2

[pointbazaar]

Let's close this issue as config validation is available as script and at runtime so there should be no problem for users who want stability there.

For

It makes think if we can ignore the ill-formed single config and continue to processed the health ones. It would make the system more robust.

it is not a bug (since configs should already be validated before use) and more of a feature enhancement for which issue author can raise a patch.

[saipavann27]

Hi @drakedog2008 @pointbazaar I am not able to recreate the issue on the evb ast2600.I have added Two json files one with proper configurations and another json configured without Name.I didnt find any application crash.

Note: if possible, could you guide me to recreate the issue?

[pointbazaar]

@saipavann27 if you cannot recreate the issue, the issue is solved, right?

What do you want to do here, do you want to search for bugs in EM?

[saipavann27]

The reported issue and attempted to reproduce it under the conditions described. Unfortunately, I was unable to replicate the behavior. In light of this, I suggest that the issue be considered for closure.