Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

versification_system() and translation_info() should lower case the translation #27

Open
curiousdannii opened this issue Jun 23, 2016 · 0 comments

Comments

@curiousdannii
Copy link

curiousdannii commented Jun 23, 2016

I've got caught out by not realising that versification_system() and translation_info() require a lower cased translation. I can't think of any downsides to them calling toLowerCase() on what is passed to them.

Also, if a versification system isn't recognised, passing it to versification_system() will keep the old versification system rather than resetting it to 'default'. Perhaps it could have a second option which would specify whether to leave the versification system as it is, or whether to reset it? We could check whether translations are supported when we call versification_system(), but that may result in a lot of duplicated code, whereas adding an option to the function means it would be self contained.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant