Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

404 error when following OSI submodule link #17

Closed
PhRosenberger opened this issue Oct 4, 2023 · 3 comments
Closed

404 error when following OSI submodule link #17

PhRosenberger opened this issue Oct 4, 2023 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@PhRosenberger
Copy link
Contributor

Describe the bug:
When I click on the OSI submodule at https://github.com/openMSL/sl-1-2-reflection-based-lidar-object-model/tree/main/lib, I get an 404 error. Should we probably change the submodule to the last commit of the SETLevel OSI main branch under https://gitlab.setlevel.de/open/osi?

@PhRosenberger PhRosenberger added the bug Something isn't working label Oct 4, 2023
@ClemensLinnhoff
Copy link
Contributor

This is odd. It already points to the last commit of https://gitlab.setlevel.de/open/osi. At least the commit ID and the url in .gitmodules match. But I will check this on a branch.

@ClemensLinnhoff
Copy link
Contributor

I just checked. When I locally pull the main branch in lib/open-simulation-interface, nothing happens. So it is already the current commit of the main branch of SETLevel OSI. I don't know why the link from the GitHub page does not work. But it also doesn't work for eigen (pointing to a GitLab) repository. So probably GitHub just does not link to GitLab.

So can we close this issue @PhRosenberger ?

@PhRosenberger
Copy link
Contributor Author

Oh ok, so it's more about GitHub not liking GitLab..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants