Skip to content

Commit 52043cc

Browse files
Merge pull request #42 from HekmatullahAmin/fix-input
fix: use app_identifier instead of macos_app_identifier for macOS publishing
2 parents 4ae9b42 + 7ed0777 commit 52043cc

File tree

2 files changed

+4
-10
lines changed

2 files changed

+4
-10
lines changed

.github/workflows/multi-platform-build-and-publish.yaml

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -161,7 +161,7 @@ on:
161161

162162
app_identifier:
163163
type: string
164-
description: 'The unique bundle identifier for the iOS application'
164+
description: 'The unique bundle identifier for the iOS and macOS application'
165165
required: true
166166

167167
git_url:
@@ -221,11 +221,6 @@ on:
221221
type: string
222222
default: 'cmp-shared/build/compose/cocoapods/compose-resources'
223223

224-
macos_app_identifier:
225-
description: 'Bundle identifier for the macOS app'
226-
type: string
227-
required: true
228-
229224
cmp_desktop_dir:
230225
description: 'Path to the Compose/KMP desktop project used for macOS build'
231226
type: string
@@ -562,7 +557,7 @@ jobs:
562557
- name: Upload macOS to TestFlight
563558
uses: openMF/mifos-x-actionhub-publish-macos-on-appstore-testflight-kmp@v1.0.0
564559
with:
565-
app_identifier: ${{ inputs.macos_app_identifier }}
560+
app_identifier: ${{ inputs.app_identifier }}
566561
cmp_desktop_dir: ${{ inputs.cmp_desktop_dir }}
567562
keychain_name: ${{ inputs.keychain_name }}
568563
java_version: ${{ inputs.java-version }}
@@ -587,7 +582,7 @@ jobs:
587582
- name: Submit macOS App to App Store
588583
uses: openMF/[email protected]
589584
with:
590-
app_identifier: ${{ inputs.macos_app_identifier }}
585+
app_identifier: ${{ inputs.app_identifier }}
591586
cmp_desktop_dir: ${{ inputs.cmp_desktop_dir }}
592587
keychain_name: ${{ inputs.keychain_name }}
593588
java_version: ${{ inputs.java-version }}

README.md

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -812,8 +812,7 @@ The workflow supports the following configuration inputs:
812812

813813
### Signing & Certificates
814814

815-
- `app_identifier`: The unique bundle identifier for the iOS application
816-
- `macos_app_identifier`: The unique bundle identifier for the macOS application
815+
- `app_identifier`: The unique bundle identifier for the iOS and macOS application
817816
- `git_url`: Git URL for certificates & provisioning profiles (Fastlane Match)
818817
- `git_branch`: Branch inside certificates repo for Match
819818
- `match_type`: Type of provisioning profile (adhoc, appstore, development)

0 commit comments

Comments
 (0)