Skip to content

Commit 4e10873

Browse files
refactor: make middle name optional (#2953)
1 parent 526b0ce commit 4e10873

File tree

1 file changed

+2
-5
lines changed

1 file changed

+2
-5
lines changed

feature/auth/src/commonMain/kotlin/org/mifos/mobile/feature/auth/registration/RegistrationViewModel.kt

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@ import mifos_mobile.feature.auth.generated.resources.feature_signup_error_first_
2222
import mifos_mobile.feature.auth.generated.resources.feature_signup_error_invalid_email
2323
import mifos_mobile.feature.auth.generated.resources.feature_signup_error_invalid_name
2424
import mifos_mobile.feature.auth.generated.resources.feature_signup_error_last_name_empty
25-
import mifos_mobile.feature.auth.generated.resources.feature_signup_error_middle_name_empty
2625
import mifos_mobile.feature.auth.generated.resources.feature_signup_error_password_mismatch
2726
import mifos_mobile.feature.auth.generated.resources.feature_signup_error_password_required_error
2827
import mifos_mobile.feature.auth.generated.resources.feature_signup_error_password_short
@@ -187,16 +186,15 @@ class RegistrationViewModel(
187186
*/
188187
@Suppress("ReturnCount")
189188
private fun validateName(name: String, nameType: String): ValidationResult? {
190-
if (name.isEmpty()) {
189+
if (name.isEmpty() && nameType != "middle") {
191190
return when (nameType) {
192191
"first" -> ValidationResult.Error(Res.string.feature_signup_error_first_name_empty)
193-
"middle" -> ValidationResult.Error(Res.string.feature_signup_error_middle_name_empty)
194192
"last" -> ValidationResult.Error(Res.string.feature_signup_error_last_name_empty)
195193
else -> ValidationResult.Error(Res.string.feature_signup_error_invalid_name)
196194
}
197195
}
198196

199-
if (!ValidationHelper.isValidName(name)) {
197+
if (name.isNotEmpty() && !ValidationHelper.isValidName(name)) {
200198
return ValidationResult.Error(Res.string.feature_signup_error_invalid_name)
201199
}
202200

@@ -628,7 +626,6 @@ data class SignUpState(
628626
val isSubmitButtonEnabled: Boolean
629627
get() = customerAccount.isNotBlank() &&
630628
firstName.isNotBlank() &&
631-
middleName.isNotBlank() &&
632629
lastName.isNotBlank() &&
633630
email.isNotBlank() &&
634631
password.isNotBlank() &&

0 commit comments

Comments
 (0)