Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: Migrate CreateNewCenterFragment to Jetpack Compose #2088

Closed
wants to merge 1 commit into from
Closed

Refactor: Migrate CreateNewCenterFragment to Jetpack Compose #2088

wants to merge 1 commit into from

Conversation

ashutosh-kumar-kushwaha
Copy link

Fixes #2077

Please Add Screenshots If there are any UI changes.

Screenshot_20240402-214705_MifosXDroid

Screenshot_20240402-214723_MifosXDroid

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Apply the MifosStyle.xml style template to your code in Android Studio.

  • Run the unit tests with ./gradlew check to make sure you didn't break anything

  • If you have multiple commits please combine them into one commit by squashing them.

@therajanmaurya
Copy link
Member

I tested the functionality, It is not same as it was implemented in XML and also search functionality is broken. I always get no result.

@ashutosh-kumar-kushwaha
Copy link
Author

I tested the functionality, It is not same as it was implemented in XML and also search functionality is broken. I always get no result.

The Create Center functionality is broken in XML as well. Always gives HTTP 400 or 500.

The progress bar was implemented inside the screen in XML, whereas I implemented it within a Dialog in Compose. I will fix that. Apart from this, I did not see any other differences.

@therajanmaurya
Copy link
Member

Can you please upload the before and after videos? I want to include this implementation in our codebase but we must maintain the code quality.

Also check why always API gives No search found but in development branch it does return on searc

@ashutosh-kumar-kushwaha
Copy link
Author

Can you please upload the before and after videos? I want to include this implementation in our codebase but we must maintain the code quality.

Before -

vidma_recorder_08042024_054412.mp4

After -

vidma_recorder_08042024_054847.mp4

Also check why always API gives No search found but in development branch it does return on searc

The SearchScreen one is a different PR. This PR is for CreateNewCenterFragment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor: Migrate CreateNewCenterFragment to Jetpack Compose
2 participants
@ashutosh-kumar-kushwaha @therajanmaurya