Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue : Collection sheet Keeps on loading even the internet is turned off #2051

Open
ghost opened this issue Dec 7, 2023 · 2 comments
Open
Assignees

Comments

@ghost
Copy link

ghost commented Dec 7, 2023

Summary:
Collection sheet Keeps on loading even the internet is turned off

Steps to reproduce:
1.Turn of the internet
2.Go to Collection reports it keeps on loading instead of showing no internet...

Expected behaviour:
Should show no internet...

Device and Android version:

What make and model device (e.g., Samsung Galaxy S3) did you encounter this on? What Android
version (e.g., Android 4.0 Ice Cream Sandwich or Android 6.0 Marshmallow) are you running? Is it
the stock
version from the manufacturer or a custom ROM?

Screenshots:

Can be created by pressing the Volume Down and Power Button at the same time on Android 4.0 and higher.

@ashutosh-kumar-kushwaha

I want to work on this. Please assign this issue to me.

@PraneGIT
Copy link

Issue Description:
The Collection Sheet feature exhibits unexpected behavior where it continues to load indefinitely even when the internet connection is disabled.

Steps to Reproduce:

Turn off the internet connection.
Navigate to the Collection Reports section.
Observe that the Collection Sheet continues to load endlessly instead of displaying a notification indicating no internet connection.
Expected Behavior:
The Collection Sheet should display a notification indicating the absence of an internet connection when the network is disabled, ensuring users are informed of the issue rather than experiencing indefinite loading.

Resolution Approach:
made changes in NewIndividualCollectionSheetViewModel.kt in fun fetchOffices(),
along with this also made changes to fun fetchStaff() which causedthe same issue when calling it without internet network.

A video demonstration for resolved code for given issue :

collectionSheetIssue.mp4

A video demonstration for resolved code for the office event also:

officeIssue.mp4

@Thanush66 @Aditya-gupta99 , please assign this issue to me for the PR that will address this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants