Skip to content

Small issue compilation #413

Open
Open
@kkoehn

Description

@kkoehn

Must have before release:

  • Exercise to task refactor
  • active storage
  • automatic collection creation and assignment on import from CO

Functionality

  • You have to verify your mail after registration, but not after a change (of the email address)
    • fix
  • simple_form is not used consistently
    • fix when necessary
  • A user can message himself (and reply)
    • Message system in general is questionable
      • refactor message system -> notification system
  • A Report-system seems to exist, but has not much functionality
    • auto hide exercise after X amount of reports
  • Messages in message-system do not show timestamps
    • fix after notification system?
  • Exercise can have multiple files with the same path
    • fix
  • Emails and internal Messages are handled separated from each other (example groups_controller l:68&70)
    • fix with notification system
  • Export to AccountLink from Cart currently disabled
    • will be deleted anyway
  • Error during import (no file for example) results in JS alert and only generic error message
    • better error message
  • In exercise new form - uploaded files will be "forgotten" after a serverside validation error
    • fix
  • The description preview in the overview should show the primary description
    • task only has one description - will fix itself
  • Specs missing for: ability, groups_controller, probably a lot more
    • add when necessary
  • After requesting to contribute to a exercise, it redirects back to the own exercises. The old filter should be reapplied or no redirect should occur (ajax)
    • fix
  • In Exercise show: when opening related exercises, comments, history it always scrolls to the bottom
    • fix
    • opening related exercises, when none are present still shows the navigation arrows left and right
      -fix
  • check for dead actions, views
    • fix when necessary
  • Long titles break formatting in exercise overview
    • fix
  • Missing FileTypes cause errors on both systems
  • Password reset doesn't work: password controller and routes got deleted in a refactoring

potential Features:

  • ability to ignore a specific Exercise in exercise-overview
  • ability to attach a personal note to an exercise
  • discussion per exercise/group/collection?
  • Markdown?-Editor for descriptions of exercise
  • show import/export links for current systems while creating account link (on both CH and CO)
  • add more right levels per exercise
    • user can request access to an exercise and append a message
    • exercise owner can choose which level of access the user gets (or reject completly)

Refactoring

  • Split large controllers, move more logic to services
  • Exercise uses a default_scope. This is an antipattern
  • ruby update introduced a lot of warnings. check stdout

Styling

  • Form errors are not correctly used in all forms
  • Html titles is always "CodeHarbor"
  • Main Page: Padding/margin between three circles missing

Technology

  • Paperclip is deprecated, switch to Active Storage
  • !!! FIX !!!
  • Sprockets update?
  • Yarn?
  • Bootstrap 4? (we use twitter-bootstrap-rails, which seems sparely updated)
  • Ransack for Exercise search

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions