Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop HealthChecker after disconnect #38

Open
confususs opened this issue Mar 4, 2020 · 0 comments
Open

Stop HealthChecker after disconnect #38

confususs opened this issue Mar 4, 2020 · 0 comments

Comments

@confususs
Copy link
Contributor

Currently when you connect a 'healthChecker' is started on transport. That one is responsible for sending periodic OPTIONS requests to the sip server to ensure the connection is still alive.

Right now it is not stopped after a disconnect, causing clients that were online and then offline to still have their healthChecker active.

Version

0.2.9

File / Feature

src/transport.ts

Expected behaviour

The healthChecker should stop when disconnect is called.

Actual behaviour

The healthChecker continues when disconnect is called.

Other info

Added ddae5f9 but it broke tests, so reverted it before publishing a new version. The better way is to add it thruogh a PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant