feat(recommended.cjs): set react-hooks/exhaustive-deps from warn to error

BREAKING CHANGE: Existing repos may comply with react-hooks/exhaustive-deps warn, but error will surface code that does not have an eslint-disable directive

Author: michaeljaltamirano

docs/breaking-changes/v18.md

@@ -1,3 +1,4 @@
 # Breaking changes in v18
 
 - `eslint-plugin-babel-compiler` superseded by `eslint-plugin-react-hooks` v7. Consumers will need to remove direct `react-compiler/react-compiler` references.
+- `react-hooks/exhaustive-deps` upgraded from "warn" to "error" severity, to match `web-schumacher-app`.

recommended.cjs

@@ -37,12 +37,26 @@ module.exports = {
         ],
       },
     ],
+    /**
+     * We enforce this as error in `web-schumacher-app`, and we should start more strictly enforcing it in other repos, too,
+     * to be more thoroughly React Compiler-compliant.
+     *
+     * {@link https://github.com/turo/web-schumacher-app/pull/10307 Schumacher PR}
+     * {@link https://react.dev/reference/eslint-plugin-react-hooks/lints/exhaustive-deps docs}
+     */
+    "react-hooks/exhaustive-deps": "error",
     /**
      * Set as "warn" by default, we want to error on incompatible library APIs for dev visibility (to require // eslint-disable)
      *
      * {@link https://react.dev/reference/eslint-plugin-react-hooks/lints/incompatible-library docs}
      */
     "react-hooks/incompatible-library": "error",
+    /**
+     * Not a rule we expect to see, but all other rules are set to "error", and so we set this one to "error" too (to require // eslint-disable)
+     *
+     * {@link https://react.dev/reference/eslint-plugin-react-hooks/lints/unsupported-syntax docs}
+     */
+    "react-hooks/unsupported-syntax": "error",
     // don't force .jsx extension
     "react/jsx-filename-extension": "off",
     // In TS you must use the Fragment syntax instead of the shorthand

test/__snapshots__/test.spec.js.snap

@@ -7997,7 +7997,7 @@ exports[`validate config the legacy recommended config is correct 1`] = `
     "error",
   ],
   "react-hooks/exhaustive-deps": [
-    "warn",
+    "error",
   ],
   "react-hooks/gating": [
     "error",
@@ -8033,7 +8033,7 @@ exports[`validate config the legacy recommended config is correct 1`] = `
     "error",
   ],
   "react-hooks/unsupported-syntax": [
-    "warn",
+    "error",
   ],
   "react-hooks/use-memo": [
     "error",