From abc65eb4a3fe7f9df0e594525bcf321614b3d252 Mon Sep 17 00:00:00 2001 From: Sylvain Juge <763082+SylvainJuge@users.noreply.github.com> Date: Wed, 20 Nov 2024 17:48:30 +0100 Subject: [PATCH 1/5] mark code.* attributes as stable --- model/code/registry.yaml | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/model/code/registry.yaml b/model/code/registry.yaml index 15621a94df..8994a323b5 100644 --- a/model/code/registry.yaml +++ b/model/code/registry.yaml @@ -7,38 +7,38 @@ groups: attributes: - id: code.function type: string - stability: experimental + stability: stable brief: > The method or function name, or equivalent (usually rightmost part of the code unit's name). examples: serveRequest - id: code.namespace type: string - stability: experimental + stability: stable brief: > The "namespace" within which `code.function` is defined. Usually the qualified class or module name, such that `code.namespace` + some separator + `code.function` form a unique identifier for the code unit. examples: com.example.MyHttpService - id: code.filepath type: string - stability: experimental + stability: stable brief: > The source code file name that identifies the code unit as uniquely as possible (preferably an absolute file path). examples: /usr/local/MyApplication/content_root/app/index.php - id: code.lineno type: int - stability: experimental + stability: stable brief: > The line number in `code.filepath` best representing the operation. It SHOULD point within the code unit named in `code.function`. examples: 42 - id: code.column type: int - stability: experimental + stability: stable brief: > The column number in `code.filepath` best representing the operation. It SHOULD point within the code unit named in `code.function`. examples: 16 - id: code.stacktrace type: string - stability: experimental + stability: stable brief: > A stacktrace as a string in the natural representation for the language runtime. The representation is to be determined and documented by each language SIG. From a90a2e56153af669b1dd0804ac3d9e1df3362b3b Mon Sep 17 00:00:00 2001 From: Sylvain Juge <763082+SylvainJuge@users.noreply.github.com> Date: Thu, 21 Nov 2024 11:15:42 +0100 Subject: [PATCH 2/5] switch to release candidate --- model/code/registry.yaml | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/model/code/registry.yaml b/model/code/registry.yaml index 8994a323b5..cd72be97d0 100644 --- a/model/code/registry.yaml +++ b/model/code/registry.yaml @@ -7,38 +7,38 @@ groups: attributes: - id: code.function type: string - stability: stable + stability: experimental # RELEASE CANDIDATE brief: > The method or function name, or equivalent (usually rightmost part of the code unit's name). examples: serveRequest - id: code.namespace type: string - stability: stable + stability: experimental # RELEASE CANDIDATE brief: > The "namespace" within which `code.function` is defined. Usually the qualified class or module name, such that `code.namespace` + some separator + `code.function` form a unique identifier for the code unit. examples: com.example.MyHttpService - id: code.filepath type: string - stability: stable + stability: experimental # RELEASE CANDIDATE brief: > The source code file name that identifies the code unit as uniquely as possible (preferably an absolute file path). examples: /usr/local/MyApplication/content_root/app/index.php - id: code.lineno type: int - stability: stable + stability: experimental # RELEASE CANDIDATE brief: > The line number in `code.filepath` best representing the operation. It SHOULD point within the code unit named in `code.function`. examples: 42 - id: code.column type: int - stability: stable + stability: experimental # RELEASE CANDIDATE brief: > The column number in `code.filepath` best representing the operation. It SHOULD point within the code unit named in `code.function`. examples: 16 - id: code.stacktrace type: string - stability: stable + stability: experimental # RELEASE CANDIDATE brief: > A stacktrace as a string in the natural representation for the language runtime. The representation is to be determined and documented by each language SIG. From ce699d825f51f2d796da2b7b6da638f178f009a0 Mon Sep 17 00:00:00 2001 From: Sylvain Juge <763082+SylvainJuge@users.noreply.github.com> Date: Thu, 21 Nov 2024 11:16:03 +0100 Subject: [PATCH 3/5] add changelog --- .chloggen/1599.yaml | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+) create mode 100644 .chloggen/1599.yaml diff --git a/.chloggen/1599.yaml b/.chloggen/1599.yaml new file mode 100644 index 0000000000..0f253e83ed --- /dev/null +++ b/.chloggen/1599.yaml @@ -0,0 +1,22 @@ +# Use this changelog template to create an entry for release notes. +# +# If your change doesn't affect end users you should instead start +# your pull request title with [chore] or use the "Skip Changelog" label. + +# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix' +change_type: enhancement + +# The name of the area of concern in the attributes-registry, (e.g. http, cloud, db) +component: code + +# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`). +note: Mark code semantic conventions as release candidate + +# Mandatory: One or more tracking issues related to the change. You can use the PR number here if no issue exists. +# The values here must be integers. +issues: [ 1377 ] + +# (Optional) One or more lines of additional information to render under the primary note. +# These lines will be padded with 2 spaces and then inserted directly into the document. +# Use pipe (|) for multiline entries. +subtext: From 4f5a41cda4cd22444eb63ace5d889336d2d53419 Mon Sep 17 00:00:00 2001 From: Sylvain Juge <763082+SylvainJuge@users.noreply.github.com> Date: Thu, 21 Nov 2024 11:18:06 +0100 Subject: [PATCH 4/5] fix go version --- internal/tools/go.mod | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/internal/tools/go.mod b/internal/tools/go.mod index 075a53d8c9..08bdfee5b0 100644 --- a/internal/tools/go.mod +++ b/internal/tools/go.mod @@ -1,6 +1,6 @@ module github.com/open-telemetry/opentelemetry-specification/internal/tools -go 1.22 +go 1.22.0 require ( github.com/client9/misspell v0.3.4 From 266d89ac4100361f816d13f92a103aa75e44066c Mon Sep 17 00:00:00 2001 From: Sylvain Juge <763082+SylvainJuge@users.noreply.github.com> Date: Mon, 25 Nov 2024 10:00:33 +0100 Subject: [PATCH 5/5] 2 spaces for markdown lint --- model/code/registry.yaml | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/model/code/registry.yaml b/model/code/registry.yaml index cd72be97d0..a47ced94f5 100644 --- a/model/code/registry.yaml +++ b/model/code/registry.yaml @@ -7,38 +7,38 @@ groups: attributes: - id: code.function type: string - stability: experimental # RELEASE CANDIDATE + stability: experimental # RELEASE CANDIDATE brief: > The method or function name, or equivalent (usually rightmost part of the code unit's name). examples: serveRequest - id: code.namespace type: string - stability: experimental # RELEASE CANDIDATE + stability: experimental # RELEASE CANDIDATE brief: > The "namespace" within which `code.function` is defined. Usually the qualified class or module name, such that `code.namespace` + some separator + `code.function` form a unique identifier for the code unit. examples: com.example.MyHttpService - id: code.filepath type: string - stability: experimental # RELEASE CANDIDATE + stability: experimental # RELEASE CANDIDATE brief: > The source code file name that identifies the code unit as uniquely as possible (preferably an absolute file path). examples: /usr/local/MyApplication/content_root/app/index.php - id: code.lineno type: int - stability: experimental # RELEASE CANDIDATE + stability: experimental # RELEASE CANDIDATE brief: > The line number in `code.filepath` best representing the operation. It SHOULD point within the code unit named in `code.function`. examples: 42 - id: code.column type: int - stability: experimental # RELEASE CANDIDATE + stability: experimental # RELEASE CANDIDATE brief: > The column number in `code.filepath` best representing the operation. It SHOULD point within the code unit named in `code.function`. examples: 16 - id: code.stacktrace type: string - stability: experimental # RELEASE CANDIDATE + stability: experimental # RELEASE CANDIDATE brief: > A stacktrace as a string in the natural representation for the language runtime. The representation is to be determined and documented by each language SIG.