From bd2a15f1f904a4b95a1c582faff5b5cfafbd788b Mon Sep 17 00:00:00 2001 From: Florian Lehner Date: Tue, 10 Sep 2024 14:33:36 +0200 Subject: [PATCH] profiles: drop Sample.label Drop `Sample.label` in favor of `Sample.attributes`. While `label` and `attributes` fulfill the same purpose, it is not defined which one choose for which information. Therefore, drop `label` in favor of `attributes`. FYI: @open-telemetry/profiling-maintainers spec:profiles --- .../proto/profiles/v1experimental/pprofextended.proto | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/opentelemetry/proto/profiles/v1experimental/pprofextended.proto b/opentelemetry/proto/profiles/v1experimental/pprofextended.proto index 46136b16..136b792f 100644 --- a/opentelemetry/proto/profiles/v1experimental/pprofextended.proto +++ b/opentelemetry/proto/profiles/v1experimental/pprofextended.proto @@ -241,16 +241,6 @@ message Sample { // result has a list of values that is the element-wise sum of the // lists of the originals. repeated int64 value = 2; - // label includes additional context for this sample. It can include - // things like a thread id, allocation size, etc. - // - // NOTE: While possible, having multiple values for the same label key is - // strongly discouraged and should never be used. Most tools (e.g. pprof) do - // not have good (or any) support for multi-value labels. And an even more - // discouraged case is having a string label and a numeric label of the same - // name on a sample. Again, possible to express, but should not be used. - // [deprecated, superseded by attributes] - repeated Label label = 3; // References to attributes in Profile.attribute_table. [optional] repeated uint64 attributes = 10;