Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement W3C Correlation Context propagator #833

Closed
mayurkale22 opened this issue Mar 3, 2020 · 5 comments · Fixed by #838
Closed

Implement W3C Correlation Context propagator #833

mayurkale22 opened this issue Mar 3, 2020 · 5 comments · Fixed by #838
Assignees
@rubenvp8510
Labels
feature-request

Comments

@mayurkale22
Copy link
Member

Propagate Correlation Context using W3C correlation context format.

See: https://w3c.github.io/correlation-context/

Reference implementation in OpenCensus: census-instrumentation/opencensus-node#445
@mayurkale22 mayurkale22 added feature-request up-for-grabs Good for taking. Extra help will be provided by maintainers labels Mar 3, 2020
@dyladan
Copy link
Member

dyladan commented Mar 3, 2020

There is no W3C correlation context propagator. This is an ongoing discussion in the W3C distributed tracing working group, but I don't think we should implement this until the spec is worked out.

@mayurkale22
Copy link
Member Author

Ah, looks like otel-go has implemented propagator based on https://w3c.github.io/correlation-context/.

@rubenvp8510
Copy link
Contributor

As part of my work on: #329 I also started something on this, Is that ok? I think I can sent a PR soon.

@dyladan
Copy link
Member

dyladan commented Mar 3, 2020

I think it makes sense for the propagator to be a separate PR. The work on #329 should only set context values, and it is up to the propagator to decide what to do with them.

@rubenvp8510
Copy link
Contributor

Yes, I'll send a separate PR.

@rubenvp8510 rubenvp8510 mentioned this issue Mar 3, 2020
Merged
@mayurkale22 mayurkale22 removed the up-for-grabs Good for taking. Extra help will be provided by maintainers label Mar 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rubenvp8510 rubenvp8510

Labels
feature-request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: implement W3C Correlation Context propagator rubenvp8510/opentelemetry-js
3 participants
@dyladan @rubenvp8510 @mayurkale22