Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Span Does Not Reference Parent Span #5345

Open
JacksonWeber opened this issue Jan 15, 2025 · 3 comments
Open

Span Does Not Reference Parent Span #5345

JacksonWeber opened this issue Jan 15, 2025 · 3 comments
Assignees
Labels
spec-feature This is a request to implement a new feature which is already specified by the OTel specification target:next-major-release This PR targets the next major release (`next` branch) type:feature A feature with no sub-issues to address

Comments

@JacksonWeber
Copy link
Contributor

Description

Currently we do not provide a parent span in the form of a Span, SpanContext, or null on Spans. We only provide the parentSpanId which does not comply with the spec.

We should add an attribute to the span to track this value. Likely called parentSpanContext. Ideally, following a similar implementation as OpenTelemetry-Java.

Describe the solution you'd like

Implement the specification

@pichlermarc
Copy link
Member

@dyladan
Copy link
Member

dyladan commented Jan 15, 2025

The interface @pichlermarc points out is the only way you'd be able to access this, but the link to otel java provided in the OP is the span implementation itself, not the readable span interface. It would be a necessary part of the implementation for the interface though.

@pichlermarc pichlermarc added spec-feature This is a request to implement a new feature which is already specified by the OTel specification type:feature A feature with no sub-issues to address target:next-major-release This PR targets the next major release (`next` branch) labels Jan 17, 2025
@pichlermarc
Copy link
Member

Summary from the SIG on Wednesday: we agreed that we should change the ReadableSpan interface to include parentSpanContext and that we'd drop parentSpanId in favor of that. This way we're specification compiant on ReadableSpan

@JacksonWeber agreed to work on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
spec-feature This is a request to implement a new feature which is already specified by the OTel specification target:next-major-release This PR targets the next major release (`next` branch) type:feature A feature with no sub-issues to address
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants