Rationale for moving @types/... to dependencies?

[astellingwerf]

I'd like to understand why in #468 @obecny moved several @types/... dependencies from devDependencies (where they typically belong) to production dependencies. It means that I ship a bunch of extra libraries, while they are not used.
Why was this change made, and would it make sense to move them back?

• This only affects the JavaScript OpenTelemetry library
• This may affect other libraries, but I would like to get opinions here first

[pichlermarc]

@blumamir has created a really good write-up of this. The reason why some of these are in dependencies is because they're in some way shape or form part of the public API of that package. When they're part of the public API and the package is not included as a dependency, it may break the typescript build for the user.

The write-up above also notes that wherever possible we should avoid this in instrumentations. We've since then removed these types from the public API wherever possible and replaced it with something else. AFAIK, there's a few packages left though that we have not gotten to or that don't have owners (see this list) at the moment.

[obecny]

@astellingwerf
Well that was a long time ago but from what I remember we had some problems and it appeared that the typescripts weren't compiled when we had them in dev packages. Those types were still needed as they were exported. We discussed this on some meeting and that was the approach we took. Please feel free to propose whatever solutions works better, as long as it compiles I think it will be good to change just maybe be sure to get "yes" from current maintainers before you start changing this to avoid any confussions or unnecessary work, thx